Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-13 03:58:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Squeeze a bit more performance out of the ends_with bif

Browse source
This commit is contained in:
Tim Wojtulewicz 2024-01-12 16:07:27 -07:00 • committed by Tim Wojtulewicz
parent 378f380b71
commit b962bd30ce
3 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/strings.bif
View file

@ -1366,9 +1366,15 @@ function ends_with%(str: string, sub: string%) : bool
if ( sub->Len() > str->Len() )
return zeek::val_mgr->Bool(false);
string s = str->ToStdString();
string sub_s = sub->ToStdString();
return zeek::val_mgr->Bool(s.rfind(sub_s) == (s.size() - sub_s.size()));
auto sub_s = sub->ToStdStringView();
auto s = str->ToStdStringView();
// Create a string_view that only looks at the end of the string being searched
// with the same number of characters as the search string. This avoids possible
// pathological searches of big strings if the search string doesn't exist.
auto end_s = std::string_view{s.data() + s.size() - sub_s.size(), sub_s.size()};
return zeek::val_mgr->Bool(end_s == sub_s);
%}
## Returns whether a string consists entirely of digits.