Integrate review feedback

This commit is contained in:
Dominik Charousset 2024-01-06 13:48:14 +01:00
parent 6132cbd13e
commit bd3e5bedbb
7 changed files with 23 additions and 22 deletions

View file

@ -105,8 +105,8 @@ public:
*/
virtual std::string InternalState() const = 0;
[[deprecated("use SerializeData instead")]] broker::expected<broker::data> Serialize() const;
[[deprecated("use UnserializeData instead")]] static std::unique_ptr<BloomFilter> Unserialize(
[[deprecated("Remove in v7.1: use SerializeData instead")]] broker::expected<broker::data> Serialize() const;
[[deprecated("Remove in v7.1: use UnserializeData instead")]] static std::unique_ptr<BloomFilter> Unserialize(
const broker::data& data);
std::optional<BrokerData> SerializeData() const;
static std::unique_ptr<BloomFilter> UnserializeData(BrokerDataView data);

View file

@ -132,7 +132,7 @@ public:
*/
ValPtr DoClone(CloneState* state) override;
DECLARE_OPAQUE_VALUE_V2(TopkVal)
DECLARE_OPAQUE_VALUE_DATA(TopkVal)
protected:
/**