SMB: fix number of small issues.

Changes:
* change virtual to override where appropriate
* analyzer triggered assert in debug mode because it did not call Done()
  on manually instantiated analyzers.
* added a few length checks to methods
* commented unused code and removed a few unused class members
This commit is contained in:
Johanna Amann 2016-06-20 14:53:48 -07:00
parent 0e49b9ef98
commit be92821a69
14 changed files with 75 additions and 65 deletions

View file

@ -19,13 +19,13 @@ public:
virtual ~GSSAPI_Analyzer();
// Overriden from Analyzer.
virtual void Done();
void Done() override;
virtual void DeliverStream(int len, const u_char* data, bool orig);
virtual void Undelivered(uint64 seq, int len, bool orig);
void DeliverStream(int len, const u_char* data, bool orig) override;
void Undelivered(uint64 seq, int len, bool orig) override;
// Overriden from tcp::TCP_ApplicationAnalyzer.
virtual void EndpointEOF(bool is_orig);
void EndpointEOF(bool is_orig) override;
static analyzer::Analyzer* Instantiate(Connection* conn)
{ return new GSSAPI_Analyzer(conn); }