Make options redef-able by default.

src/ID.cc

@@ -294,6 +294,22 @@ void ID::RemoveAttr(attr_tag a)
 		}
 	}
 
+void ID::SetOption()
+	{
+	if ( is_option )
+		return;
+
+	is_option = true;
+
+	// option implied redefinable
+	if ( ! IsRedefinable() )
+		{
+		attr_list* attr = new attr_list;
+		attr->append(new Attr(ATTR_REDEF));
+		AddAttrs(new Attributes(attr, Type(), false));
+		}
+	}
+
 void ID::EvalFunc(Expr* ef, Expr* ev)
 	{
 	Expr* arg1 = new ConstExpr(val->Ref());

src/ID.h

@@ -60,7 +60,7 @@ public:
 	void SetConst()			{ is_const = true; }
 	bool IsConst() const		{ return is_const; }
 
-	void SetOption()			{ is_option = true; }
+	void SetOption();
 	bool IsOption() const		{ return is_option; }
 
 	void SetEnumConst()		{ is_enum_const = true; }

testing/btest/Baseline/core.option-redef/.stdout

@@ -1 +1,2 @@
 6
+7

testing/btest/core/option-redef.bro

@@ -2,11 +2,15 @@
 # @TEST-EXEC: btest-diff .stdout
 
 # options are allowed to be redef-able.
+# And they are even redef-able by default.
 
 option testopt = 5 &redef;
 redef testopt = 6;
+option anotheropt = 6;
+redef anotheropt = 7;
 
 event bro_init() {
 	print testopt;
+	print anotheropt;
 }