Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-12 19:48:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix clang-tidy performance-inefficient-string-concatenation warnings

Browse source
This commit is contained in:
Tim Wojtulewicz 2025-04-25 16:57:22 -07:00
parent cb8c35748a
commit c609d5c90a
7 changed files with 15 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/script_opt/CPP/Driver.cc
View file

@ -341,9 +341,12 @@ void CPPCompile::RegisterCompiledBody(const string& f) {
auto be = body_events.find(f);
if ( be != body_events.end() )
for ( const auto& e : be->second ) {
if ( events.size() > 0 )
if ( ! events.empty() )
events += ", ";
events = events + "\"" + e + "\"";
events += "\"";
events += e;
events += "\"";
}
events = string("{") + events + "}";

4
src/script_opt/CPP/Exprs.cc
View file

@ -28,7 +28,7 @@ string CPPCompile::GenListExpr(const Expr* e, GenType gt, bool nested) {
if ( nested && e_i->Tag() == EXPR_LIST )
// These are table or set indices.
gen_i = string("index_val__CPP({") + gen_i + "})";
gen_i = util::fmt("index_val__CPP({%s})", gen_i.c_str());
gen += gen_i;
@ -1196,7 +1196,7 @@ string CPPCompile::GenLambdaClone(const LambdaExpr* l, bool all_deep) {
if ( captures && ! IsNativeType(id_t) ) {
for ( const auto& c : *captures )
if ( id == c.Id() && (c.IsDeepCopy() || all_deep) )
arg = string("cast_intrusive<") + TypeName(id_t) + ">(" + arg + "->Clone())";
arg = util::fmt("cast_intrusive<%s>(%s->Clone())", TypeName(id_t), arg.c_str());
}
cl_args += ", " + arg;

2
src/script_opt/CPP/Inits.cc
View file

@ -299,7 +299,7 @@ void CPPCompile::GenStandaloneActivation() {
hashes += Fmt(h);
}
hashes = "{" + hashes + "}";
hashes = std::string{"{"}.append(hashes).append("}");
auto f = fb.first;
const auto& fn = f->GetName();