Merge remote-tracking branch 'origin/topic/timw/3662-ignore-disabled-writer-frontends'

* origin/topic/timw/3662-ignore-disabled-writer-frontends:
  Don't attempt to stop or flush disabled writer frontends

CHANGES

@@ -1,3 +1,7 @@
+7.0.0-dev.147 | 2024-04-22 17:08:25 -0700
+
+  * Don't attempt to stop or flush disabled writer frontends (Tim Wojtulewicz, Corelight)
+
 7.0.0-dev.145 | 2024-04-22 15:55:53 -0700
 
   * Allow SMB_TCP record to contain multiple protocol identifiers/headers (Tim Wojtulewicz, Corelight)

VERSION

@@ -1 +1 @@
-7.0.0-dev.145
+7.0.0-dev.147

src/logging/WriterFrontend.cc

@@ -133,6 +133,11 @@ WriterFrontend::~WriterFrontend() {
 }
 
 void WriterFrontend::Stop() {
+    if ( disabled ) {
+        CleanupWriteBuffer();
+        return;
+    }
+
     FlushWriteBuffer();
     SetDisable();
 
@@ -204,6 +209,11 @@ void WriterFrontend::Write(int arg_num_fields, Value** vals) {
 }
 
 void WriterFrontend::FlushWriteBuffer() {
+    if ( disabled ) {
+        CleanupWriteBuffer();
+        return;
+    }
+
     if ( ! write_buffer_pos )
         // Nothing to do.
         return;
@@ -261,4 +271,16 @@ void WriterFrontend::DeleteVals(int num_fields, Value** vals) {
     delete[] vals;
 }
 
+void WriterFrontend::CleanupWriteBuffer() {
+    if ( ! write_buffer || write_buffer_pos == 0 )
+        return;
+
+    for ( int j = 0; j < write_buffer_pos; j++ )
+        DeleteVals(num_fields, write_buffer[j]);
+
+    delete[] write_buffer;
+    write_buffer = nullptr;
+    write_buffer_pos = 0;
+}
+
 } // namespace zeek::logging

src/logging/WriterFrontend.h

@@ -206,6 +206,9 @@ protected:
     static const int WRITER_BUFFER_SIZE = 1000;
     int write_buffer_pos;             // Position of next write in buffer.
     threading::Value*** write_buffer; // Buffer of size WRITER_BUFFER_SIZE.
+
+private:
+    void CleanupWriteBuffer();
 };
 
 } // namespace zeek::logging