Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-09 01:58:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Merge remote-tracking branch 'origin/topic/jsiwek/coverity'

Browse source 
* origin/topic/jsiwek/coverity:
  Fix uninitialized (or unused) fields.
  Remove logically dead code.
  Remove dead/unfinished code in unary not expr.
  Fix logic for failed DNS TXT lookups.
  A couple null ptr checks.
  Improve return value checking and error handling.
  Remove unused variable assignments, dead code.
  Prevent division/modulo by zero in scripts.
  Fix unintentional always-false condition.
  Fix invalidated iterator usage.
  Fix DNS_Mgr iterator mismatch.
  Set safe umask when creating script profiler tmp files.
  Fix nesting/indent level whitespace mismatch.
  Add checks to avoid improper negative values use.

BIT-1085 #merged
This commit is contained in:
Robin Sommer 2013-10-02 11:03:29 -07:00
commit d127d8d01d
86 changed files with 517 additions and 242 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/Serializer.cc
View file

@ -136,7 +136,14 @@ bool Serializer::Serialize(SerialInfo* info, const char* func, val_list* args)
Write(network_time, "time");
Write(a, "len");
loop_over_list(*args, i) (*args)[i]->Serialize(info);
loop_over_list(*args, i)
{
if ( ! (*args)[i]->Serialize(info) )
{
Error("failed");
return false;
}
}
WriteCloseTag("call");
WriteSeparator();
@ -1032,6 +1039,7 @@ void ConversionSerializer::GotPacket(Packet* p)
}
EventPlayer::EventPlayer(const char* file)
: stream_time(), replay_time(), ne_time(), ne_handler(), ne_args()
{
if ( ! OpenFile(file, true) || fd < 0 )
Error(fmt("event replayer: cannot open %s", file));