Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-09 01:58:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Type: RecordType::FieldDefault() returns IntrusivePtr

Browse source 
Fixes memory leak in EventHandler::NewEvent().
This commit is contained in:
Max Kellermann 2020-03-04 21:24:31 +01:00
parent d2961c72e1
commit d180ab0dd2
4 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/EventHandler.cc
View file

@ -138,7 +138,7 @@ void EventHandler::NewEvent(val_list* vl)
{
const char* fname = args->FieldName(i);
BroType* ftype = args->FieldType(i);
Val* fdefault = args->FieldDefault(i);
auto fdefault = args->FieldDefault(i);
auto rec = make_intrusive<RecordVal>(call_argument);
rec->Assign(0, make_intrusive<StringVal>(fname));
@ -149,10 +149,7 @@ void EventHandler::NewEvent(val_list* vl)
rec->Assign(1, make_intrusive<StringVal>(d.Description()));
if ( fdefault )
{
Ref(fdefault);
rec->Assign(2, fdefault);
}
rec->Assign(2, std::move(fdefault));
if ( i < vl->length() && (*vl)[i] )
{