Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-05 16:18:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Mark input/output message classes as final, since nothing should be inheriting from them

Browse source
This commit is contained in:
Tim Wojtulewicz 2020-03-26 16:10:08 -07:00
parent 186005133b
commit d614756a7f
5 changed files with 26 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/input/ReaderBackend.cc
View file

@ -9,7 +9,7 @@ using threading::Field;
namespace input { namespace input {
class PutMessage : public threading::OutputMessage<ReaderFrontend> { class PutMessage final : public threading::OutputMessage<ReaderFrontend> {
public: public:
PutMessage(ReaderFrontend* reader, Value* *val) PutMessage(ReaderFrontend* reader, Value* *val)
: threading::OutputMessage<ReaderFrontend>("Put", reader), : threading::OutputMessage<ReaderFrontend>("Put", reader),
@ -25,7 +25,7 @@ private:
Value* *val; Value* *val;
}; };
class DeleteMessage : public threading::OutputMessage<ReaderFrontend> { class DeleteMessage final : public threading::OutputMessage<ReaderFrontend> {
public: public:
DeleteMessage(ReaderFrontend* reader, Value* *val) DeleteMessage(ReaderFrontend* reader, Value* *val)
: threading::OutputMessage<ReaderFrontend>("Delete", reader), : threading::OutputMessage<ReaderFrontend>("Delete", reader),
@ -40,7 +40,7 @@ private:
Value* *val; Value* *val;
}; };
class ClearMessage : public threading::OutputMessage<ReaderFrontend> { class ClearMessage final : public threading::OutputMessage<ReaderFrontend> {
public: public:
ClearMessage(ReaderFrontend* reader) ClearMessage(ReaderFrontend* reader)
: threading::OutputMessage<ReaderFrontend>("Clear", reader) {} : threading::OutputMessage<ReaderFrontend>("Clear", reader) {}
@ -54,7 +54,7 @@ public:
private: private:
}; };
class SendEventMessage : public threading::OutputMessage<ReaderFrontend> { class SendEventMessage final : public threading::OutputMessage<ReaderFrontend> {
public: public:
SendEventMessage(ReaderFrontend* reader, const char* name, const int num_vals, Value* *val) SendEventMessage(ReaderFrontend* reader, const char* name, const int num_vals, Value* *val)
: threading::OutputMessage<ReaderFrontend>("SendEvent", reader), : threading::OutputMessage<ReaderFrontend>("SendEvent", reader),
@ -78,7 +78,7 @@ private:
Value* *val; Value* *val;
}; };
class ReaderErrorMessage : public threading::OutputMessage<ReaderFrontend> class ReaderErrorMessage final : public threading::OutputMessage<ReaderFrontend>
{ {
public: public:
enum Type { enum Type {
@ -98,7 +98,7 @@ private:
Type type; Type type;
}; };
class SendEntryMessage : public threading::OutputMessage<ReaderFrontend> { class SendEntryMessage final : public threading::OutputMessage<ReaderFrontend> {
public: public:
SendEntryMessage(ReaderFrontend* reader, Value* *val) SendEntryMessage(ReaderFrontend* reader, Value* *val)
: threading::OutputMessage<ReaderFrontend>("SendEntry", reader), : threading::OutputMessage<ReaderFrontend>("SendEntry", reader),
@ -114,7 +114,7 @@ private:
Value* *val; Value* *val;
}; };
class EndCurrentSendMessage : public threading::OutputMessage<ReaderFrontend> { class EndCurrentSendMessage final : public threading::OutputMessage<ReaderFrontend> {
public: public:
EndCurrentSendMessage(ReaderFrontend* reader) EndCurrentSendMessage(ReaderFrontend* reader)
: threading::OutputMessage<ReaderFrontend>("EndCurrentSend", reader) {} : threading::OutputMessage<ReaderFrontend>("EndCurrentSend", reader) {}
@ -128,7 +128,7 @@ public:
private: private:
}; };
class EndOfDataMessage : public threading::OutputMessage<ReaderFrontend> { class EndOfDataMessage final : public threading::OutputMessage<ReaderFrontend> {
public: public:
EndOfDataMessage(ReaderFrontend* reader) EndOfDataMessage(ReaderFrontend* reader)
: threading::OutputMessage<ReaderFrontend>("EndOfData", reader) {} : threading::OutputMessage<ReaderFrontend>("EndOfData", reader) {}
@ -142,7 +142,7 @@ public:
private: private:
}; };
class ReaderClosedMessage : public threading::OutputMessage<ReaderFrontend> { class ReaderClosedMessage final : public threading::OutputMessage<ReaderFrontend> {
public: public:
ReaderClosedMessage(ReaderFrontend* reader) ReaderClosedMessage(ReaderFrontend* reader)
: threading::OutputMessage<ReaderFrontend>("ReaderClosed", reader) {} : threading::OutputMessage<ReaderFrontend>("ReaderClosed", reader) {}
@ -156,7 +156,7 @@ public:
private: private:
}; };
class DisableMessage : public threading::OutputMessage<ReaderFrontend> class DisableMessage final : public threading::OutputMessage<ReaderFrontend>
{ {
public: public:
DisableMessage(ReaderFrontend* writer) DisableMessage(ReaderFrontend* writer)

4
src/input/ReaderFrontend.cc
View file

@ -6,7 +6,7 @@
namespace input { namespace input {
class InitMessage : public threading::InputMessage<ReaderBackend> class InitMessage final : public threading::InputMessage<ReaderBackend>
{ {
public: public:
InitMessage(ReaderBackend* backend, InitMessage(ReaderBackend* backend,
@ -24,7 +24,7 @@ private:
const threading::Field* const* fields; const threading::Field* const* fields;
}; };
class UpdateMessage : public threading::InputMessage<ReaderBackend> class UpdateMessage final : public threading::InputMessage<ReaderBackend>
{ {
public: public:
UpdateMessage(ReaderBackend* backend) UpdateMessage(ReaderBackend* backend)

6
src/logging/WriterBackend.cc
View file

@ -16,7 +16,7 @@ using threading::Field;
namespace logging { namespace logging {
class RotationFinishedMessage : public threading::OutputMessage<WriterFrontend> class RotationFinishedMessage final : public threading::OutputMessage<WriterFrontend>
{ {
public: public:
RotationFinishedMessage(WriterFrontend* writer, const char* new_name, const char* old_name, RotationFinishedMessage(WriterFrontend* writer, const char* new_name, const char* old_name,
@ -45,7 +45,7 @@ private:
bool terminating; bool terminating;
}; };
class FlushWriteBufferMessage : public threading::OutputMessage<WriterFrontend> class FlushWriteBufferMessage final : public threading::OutputMessage<WriterFrontend>
{ {
public: public:
FlushWriteBufferMessage(WriterFrontend* writer) FlushWriteBufferMessage(WriterFrontend* writer)
@ -54,7 +54,7 @@ public:
bool Process() override { Object()->FlushWriteBuffer(); return true; } bool Process() override { Object()->FlushWriteBuffer(); return true; }
}; };
class DisableMessage : public threading::OutputMessage<WriterFrontend> class DisableMessage final : public threading::OutputMessage<WriterFrontend>
{ {
public: public:
DisableMessage(WriterFrontend* writer) DisableMessage(WriterFrontend* writer)

10
src/logging/WriterFrontend.cc
View file

@ -14,7 +14,7 @@ namespace logging {
// Messages sent from frontend to backend (i.e., "InputMessages"). // Messages sent from frontend to backend (i.e., "InputMessages").
class InitMessage : public threading::InputMessage<WriterBackend> class InitMessage final : public threading::InputMessage<WriterBackend>
{ {
public: public:
InitMessage(WriterBackend* backend, const int num_fields, const Field* const* fields) InitMessage(WriterBackend* backend, const int num_fields, const Field* const* fields)
@ -30,7 +30,7 @@ private:
const Field * const* fields; const Field * const* fields;
}; };
class RotateMessage : public threading::InputMessage<WriterBackend> class RotateMessage final : public threading::InputMessage<WriterBackend>
{ {
public: public:
RotateMessage(WriterBackend* backend, WriterFrontend* frontend, const char* rotated_path, const double open, RotateMessage(WriterBackend* backend, WriterFrontend* frontend, const char* rotated_path, const double open,
@ -52,7 +52,7 @@ private:
const bool terminating; const bool terminating;
}; };
class WriteMessage : public threading::InputMessage<WriterBackend> class WriteMessage final : public threading::InputMessage<WriterBackend>
{ {
public: public:
WriteMessage(WriterBackend* backend, int num_fields, int num_writes, Value*** vals) WriteMessage(WriterBackend* backend, int num_fields, int num_writes, Value*** vals)
@ -67,7 +67,7 @@ private:
Value ***vals; Value ***vals;
}; };
class SetBufMessage : public threading::InputMessage<WriterBackend> class SetBufMessage final : public threading::InputMessage<WriterBackend>
{ {
public: public:
SetBufMessage(WriterBackend* backend, const bool enabled) SetBufMessage(WriterBackend* backend, const bool enabled)
@ -80,7 +80,7 @@ private:
const bool enabled; const bool enabled;
}; };
class FlushMessage : public threading::InputMessage<WriterBackend> class FlushMessage final : public threading::InputMessage<WriterBackend>
{ {
public: public:
FlushMessage(WriterBackend* backend, double network_time) FlushMessage(WriterBackend* backend, double network_time)

12
src/threading/MsgThread.cc
View file

@ -15,7 +15,7 @@ namespace threading {
////// Messages. ////// Messages.
// Signals child thread to shutdown operation. // Signals child thread to shutdown operation.
class FinishMessage : public InputMessage<MsgThread> class FinishMessage final : public InputMessage<MsgThread>
{ {
public: public:
FinishMessage(MsgThread* thread, double network_time) : InputMessage<MsgThread>("Finish", thread), FinishMessage(MsgThread* thread, double network_time) : InputMessage<MsgThread>("Finish", thread),
@ -34,7 +34,7 @@ private:
}; };
// Signals main thread that operations shut down. // Signals main thread that operations shut down.
class FinishedMessage : public OutputMessage<MsgThread> class FinishedMessage final : public OutputMessage<MsgThread>
{ {
public: public:
FinishedMessage(MsgThread* thread) FinishedMessage(MsgThread* thread)
@ -48,7 +48,7 @@ public:
}; };
/// Sends a heartbeat to the child thread. /// Sends a heartbeat to the child thread.
class HeartbeatMessage : public InputMessage<MsgThread> class HeartbeatMessage final : public InputMessage<MsgThread>
{ {
public: public:
HeartbeatMessage(MsgThread* thread, double arg_network_time, double arg_current_time) HeartbeatMessage(MsgThread* thread, double arg_network_time, double arg_current_time)
@ -65,7 +65,7 @@ private:
}; };
// A message from the child to be passed on to the Reporter. // A message from the child to be passed on to the Reporter.
class ReporterMessage : public OutputMessage<MsgThread> class ReporterMessage final : public OutputMessage<MsgThread>
{ {
public: public:
enum Type { enum Type {
@ -87,7 +87,7 @@ private:
}; };
// A message from the the child to the main process, requesting suicide. // A message from the the child to the main process, requesting suicide.
class KillMeMessage : public OutputMessage<MsgThread> class KillMeMessage final : public OutputMessage<MsgThread>
{ {
public: public:
KillMeMessage(MsgThread* thread) KillMeMessage(MsgThread* thread)
@ -104,7 +104,7 @@ public:
#ifdef DEBUG #ifdef DEBUG
// A debug message from the child to be passed on to the DebugLogger. // A debug message from the child to be passed on to the DebugLogger.
class DebugMessage : public OutputMessage<MsgThread> class DebugMessage final : public OutputMessage<MsgThread>
{ {
public: public:
DebugMessage(DebugStream arg_stream, MsgThread* thread, const char* arg_msg) DebugMessage(DebugStream arg_stream, MsgThread* thread, const char* arg_msg)