Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

binpac: Add a comment in the generated C++ code for fall through in switch

Browse source 
A common BinPAC construct for parsing records is a switch statement,
with no breaks between the cases, as control is expected to fall
through.

Coverity raises an error about this; this commit should fix that.
This commit is contained in:
Vlad Grigorescu 2016-05-06 15:07:05 -05:00 • committed by Tim Wojtulewicz
parent a9d294528d
commit dc49b0343f
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tools/binpac/src/pac_record.cc
View file

@ -446,6 +446,7 @@ void RecordDataField::GenParseCode(Output* out_cc, Env* env)
out_cc->println("%s = %d;", out_cc->println("%s = %d;",
env->LValue(parsing_state_id), env->LValue(parsing_state_id),
parsing_state_seq()); parsing_state_seq());
out_cc->println("/* fall through */");
out_cc->dec_indent(); out_cc->dec_indent();
out_cc->println("case %d:", parsing_state_seq()); out_cc->println("case %d:", parsing_state_seq());
out_cc->inc_indent(); out_cc->inc_indent();