Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

RuleActionMIME: Switch to std::string

Browse source 
And return const std::string& from GetMIME(). Probably not at all performance
relevant, but while I'm already here.
This commit is contained in:
Arne Welzel 2023-11-30 10:11:51 +01:00
parent a7b077aa17
commit e8241e16ee
2 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/RuleAction.cc
View file

@ -69,12 +69,9 @@ void RuleActionEvent::PrintDebug() {
fprintf(stderr, " RuleActionEvent: |%s (%s)|\n", msg ? msg->CheckString() : "<none>", handler->Name()); fprintf(stderr, " RuleActionEvent: |%s (%s)|\n", msg ? msg->CheckString() : "<none>", handler->Name());
} }
RuleActionMIME::RuleActionMIME(const char* arg_mime, int arg_strength) { RuleActionMIME::RuleActionMIME(const char* arg_mime, int arg_strength) : mime(arg_mime), strength(arg_strength) {}
mime = util::copy_string(arg_mime);
strength = arg_strength;
}
void RuleActionMIME::PrintDebug() { fprintf(stderr, " RuleActionMIME: |%s|\n", mime); } void RuleActionMIME::PrintDebug() { fprintf(stderr, " RuleActionMIME: |%s|\n", mime.c_str()); }
RuleActionAnalyzer::RuleActionAnalyzer(const char* arg_analyzer) { RuleActionAnalyzer::RuleActionAnalyzer(const char* arg_analyzer) {
string str(arg_analyzer); string str(arg_analyzer);

6
src/RuleAction.h
View file

@ -46,18 +46,16 @@ class RuleActionMIME : public RuleAction {
public: public:
explicit RuleActionMIME(const char* arg_mime, int arg_strength = 0); explicit RuleActionMIME(const char* arg_mime, int arg_strength = 0);
~RuleActionMIME() override { delete[] mime; }
void DoAction(const Rule* parent, RuleEndpointState* state, const u_char* data, int len) override {} void DoAction(const Rule* parent, RuleEndpointState* state, const u_char* data, int len) override {}
void PrintDebug() override; void PrintDebug() override;
std::string GetMIME() const { return mime; } const std::string& GetMIME() const { return mime; }
int GetStrength() const { return strength; } int GetStrength() const { return strength; }
private: private:
const char* mime; std::string mime;
int strength; int strength;
}; };