Val: eliminate the "BroString.h" include

src/CompHash.cc

@@ -3,6 +3,7 @@
 #include "zeek-config.h"
 
 #include "CompHash.h"
+#include "BroString.h"
 #include "Dict.h"
 #include "Val.h"
 #include "Reporter.h"

src/DNS_Mgr.cc

@@ -31,6 +31,7 @@
 
 #include <algorithm>
 
+#include "BroString.h"
 #include "Event.h"
 #include "Net.h"
 #include "Val.h"

src/Discard.cc

@@ -6,6 +6,7 @@
 
 #include <algorithm>
 
+#include "BroString.h"
 #include "Net.h"
 #include "Func.h"
 #include "Var.h"

src/IP.cc

@@ -10,6 +10,7 @@
 #include "Type.h"
 #include "Val.h"
 #include "Var.h"
+#include "BroString.h"
 #include "Reporter.h"
 
 static RecordType* ip4_hdr_type = 0;

src/RuleMatcher.cc

@@ -7,6 +7,7 @@
 
 #include "RuleAction.h"
 #include "RuleCondition.h"
+#include "BroString.h"
 #include "ID.h"
 #include "IntSet.h"
 #include "IP.h"

src/Val.cc

@@ -14,6 +14,7 @@
 #include <stdlib.h>
 
 #include "Attr.h"
+#include "BroString.h"
 #include "CompHash.h"
 #include "Dict.h"
 #include "Net.h"
@@ -998,6 +999,26 @@ StringVal::StringVal(const string& s) : Val(TYPE_STRING)
 	val.string_val = new BroString(reinterpret_cast<const u_char*>(s.data()), s.length(), 1);
 	}
 
+Val* StringVal::SizeVal() const
+	{
+	return val_mgr->GetCount(val.string_val->Len());
+	}
+
+int StringVal::Len()
+	{
+	return AsString()->Len();
+	}
+
+const u_char* StringVal::Bytes()
+	{
+	return AsString()->Bytes();
+	}
+
+const char* StringVal::CheckString()
+	{
+	return AsString()->CheckString();
+	}
+
 string StringVal::ToStdString() const
 	{
 	auto* bs = AsString();

src/Val.h

@@ -3,7 +3,6 @@
 #pragma once
 
 #include "Type.h"
-#include "BroString.h"
 #include "Timer.h"
 #include "Notifier.h"
 #include "RE.h"
@@ -33,6 +32,7 @@ template<typename T> class PDict;
 class IterCookie;
 
 class Val;
+class BroString;
 class BroFunc;
 class Func;
 class BroFile;
@@ -546,12 +546,11 @@ public:
 	explicit StringVal(const string& s);
 	StringVal(int length, const char* s);
 
-	Val* SizeVal() const override
+	Val* SizeVal() const override;
-		{ return val_mgr->GetCount(val.string_val->Len()); }
 
-	int Len()		{ return AsString()->Len(); }
+	int Len();
-	const u_char* Bytes()	{ return AsString()->Bytes(); }
+	const u_char* Bytes();
-	const char* CheckString() { return AsString()->CheckString(); }
+	const char* CheckString();
 
 	// Note that one needs to de-allocate the return value of
 	// ExpandedString() to avoid a memory leak.

src/analyzer/Analyzer.cc

@@ -7,6 +7,7 @@
 #include "binpac.h"
 
 #include "analyzer/protocol/pia/PIA.h"
+#include "../BroString.h"
 #include "../Event.h"
 
 namespace analyzer {

src/analyzer/protocol/dns/DNS.cc

@@ -9,6 +9,7 @@
 #include <netinet/in.h>
 #include <arpa/inet.h>
 
+#include "BroString.h"
 #include "NetVar.h"
 #include "Sessions.h"
 #include "Event.h"

src/analyzer/protocol/ftp/FTP.cc

@@ -5,6 +5,7 @@
 
 #include <stdlib.h>
 
+#include "BroString.h"
 #include "NetVar.h"
 #include "Event.h"
 #include "Base64.h"

src/analyzer/protocol/gtpv1/gtpv1-analyzer.pac

@@ -1,5 +1,6 @@
 %extern{
 #include "Sessions.h"
+#include "BroString.h"
 %}
 
 %code{

src/analyzer/protocol/ident/Ident.cc

@@ -4,6 +4,7 @@
 
 #include <ctype.h>
 
+#include "BroString.h"
 #include "NetVar.h"
 #include "Ident.h"
 #include "Event.h"

src/analyzer/protocol/login/Login.cc

@@ -6,6 +6,7 @@
 #include <ctype.h>
 #include <stdlib.h>
 
+#include "BroString.h"
 #include "NetVar.h"
 #include "RE.h"
 #include "Reporter.h"

src/analyzer/protocol/login/NVT.cc

@@ -5,6 +5,7 @@
 
 #include <stdlib.h>
 
+#include "BroString.h"
 #include "NetVar.h"
 #include "Event.h"
 #include "Reporter.h"

src/analyzer/protocol/netbios/NetbiosSSN.cc

@@ -5,6 +5,7 @@
 
 #include <ctype.h>
 
+#include "BroString.h"
 #include "NetVar.h"
 #include "Sessions.h"
 #include "Event.h"

src/analyzer/protocol/rpc/MOUNT.cc

@@ -6,6 +6,7 @@
 #include <algorithm>
 #include <vector>
 
+#include "BroString.h"
 #include "NetVar.h"
 #include "XDR.h"
 #include "Event.h"

src/analyzer/protocol/rpc/NFS.cc

@@ -6,6 +6,7 @@
 #include <utility>
 #include <vector>
 
+#include "BroString.h"
 #include "NetVar.h"
 #include "XDR.h"
 #include "Event.h"

src/analyzer/protocol/ssh/ssh-protocol.pac

@@ -1,5 +1,9 @@
 %include consts.pac
 
+%extern{
+#include "BroString.h"
+%}
+
 # Common constructs across SSH1 and SSH2
 ########################################
 

src/analyzer/protocol/tcp/TCP_Reassembler.cc

@@ -3,6 +3,7 @@
 #include "File.h"
 #include "analyzer/Analyzer.h"
 #include "analyzer/protocol/tcp/TCP.h"
+#include "BroString.h"
 #include "Reporter.h"
 #include "RuleMatcher.h"
 

src/analyzer/protocol/teredo/Teredo.cc

@@ -5,6 +5,7 @@
 #include "IP.h"
 #include "Reporter.h"
 #include "Sessions.h"
+#include "BroString.h"
 
 #include "events.bif.h"
 

src/supervisor/Supervisor.cc

@@ -13,6 +13,7 @@
 #include <sstream>
 
 #include "iosource/Manager.h"
+#include "BroString.h"
 #include "Dict.h"
 #include "Reporter.h"
 #include "Scope.h"