Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 22:58:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Mark some overridden functions with override keyword

Browse source
This commit is contained in:
Tim Wojtulewicz 2023-07-06 15:53:55 -07:00
parent 64b78f6fb9
commit ec7ec2aa42
8 changed files with 24 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/DNS_Mgr.cc
View file

@ -1610,7 +1610,7 @@ class TestDNS_Mgr final : public DNS_Mgr
{ {
public: public:
explicit TestDNS_Mgr(DNS_MgrMode mode) : DNS_Mgr(mode) { } explicit TestDNS_Mgr(DNS_MgrMode mode) : DNS_Mgr(mode) { }
void Process(); void Process() override;
}; };
void TestDNS_Mgr::Process() void TestDNS_Mgr::Process()

8
src/ScriptValidation.cc
View file

@ -14,7 +14,7 @@ class BreakNextScriptValidation : public TraversalCallback
public: public:
BreakNextScriptValidation(bool _report) : report(_report) { } BreakNextScriptValidation(bool _report) : report(_report) { }
TraversalCode PreStmt(const Stmt* stmt) TraversalCode PreStmt(const Stmt* stmt) override
{ {
if ( ! StmtIsRelevant(stmt) ) if ( ! StmtIsRelevant(stmt) )
return TC_CONTINUE; return TC_CONTINUE;
@ -31,7 +31,7 @@ public:
return TC_CONTINUE; return TC_CONTINUE;
} }
TraversalCode PostStmt(const Stmt* stmt) TraversalCode PostStmt(const Stmt* stmt) override
{ {
if ( ! StmtIsRelevant(stmt) ) if ( ! StmtIsRelevant(stmt) )
return TC_CONTINUE; return TC_CONTINUE;
@ -43,7 +43,7 @@ public:
return TC_CONTINUE; return TC_CONTINUE;
} }
TraversalCode PreFunction(const zeek::Func* func) TraversalCode PreFunction(const zeek::Func* func) override
{ {
if ( func->Flavor() == zeek::FUNC_FLAVOR_HOOK ) if ( func->Flavor() == zeek::FUNC_FLAVOR_HOOK )
++hook_depth; ++hook_depth;
@ -53,7 +53,7 @@ public:
return TC_CONTINUE; return TC_CONTINUE;
} }
TraversalCode PostFunction(const zeek::Func* func) TraversalCode PostFunction(const zeek::Func* func) override
{ {
if ( func->Flavor() == zeek::FUNC_FLAVOR_HOOK ) if ( func->Flavor() == zeek::FUNC_FLAVOR_HOOK )
--hook_depth; --hook_depth;

4
src/Trigger.cc
View file

@ -31,7 +31,7 @@ public:
{ {
} }
virtual TraversalCode PreExpr(const Expr*) override; TraversalCode PreExpr(const Expr*) override;
private: private:
IDSet& globals; IDSet& globals;
@ -76,7 +76,7 @@ public:
time = run_state::network_time; time = run_state::network_time;
} }
~TriggerTimer() { Unref(trigger); } ~TriggerTimer() override { Unref(trigger); }
void Dispatch(double t, bool is_expire) override void Dispatch(double t, bool is_expire) override
{ {

2
src/Type.cc
View file

@ -1024,7 +1024,7 @@ class DirectManagedFieldInit final : public FieldInit
{ {
public: public:
DirectManagedFieldInit(ZVal _init_val) : init_val(_init_val) { } DirectManagedFieldInit(ZVal _init_val) : init_val(_init_val) { }
~DirectManagedFieldInit() { ZVal::DeleteManagedType(init_val); } ~DirectManagedFieldInit() override { ZVal::DeleteManagedType(init_val); }
ZVal Generate() const override ZVal Generate() const override
{ {

2
src/analyzer/Analyzer.cc
View file

@ -20,7 +20,7 @@ public:
AnalyzerTimer(Analyzer* arg_analyzer, analyzer_timer_func arg_timer, double arg_t, AnalyzerTimer(Analyzer* arg_analyzer, analyzer_timer_func arg_timer, double arg_t,
int arg_do_expire, zeek::detail::TimerType arg_type); int arg_do_expire, zeek::detail::TimerType arg_type);
virtual ~AnalyzerTimer(); ~AnalyzerTimer() override;
void Dispatch(double t, bool is_expire) override; void Dispatch(double t, bool is_expire) override;

2
src/logging/WriterFrontend.cc
View file

@ -41,7 +41,7 @@ public:
{ {
} }
virtual ~RotateMessage() { delete[] rotated_path; } ~RotateMessage() override { delete[] rotated_path; }
bool Process() override { return Object()->Rotate(rotated_path, open, close, terminating); } bool Process() override { return Object()->Rotate(rotated_path, open, close, terminating); }

4
src/scan.l
View file

@ -811,11 +811,11 @@ void begin_RE()
BEGIN(RE); BEGIN(RE);
} }
class LocalNameFinder : public zeek::detail::TraversalCallback { class LocalNameFinder final : public zeek::detail::TraversalCallback {
public: public:
LocalNameFinder() = default; LocalNameFinder() = default;
virtual zeek::detail::TraversalCode PreExpr(const zeek::detail::Expr* expr) zeek::detail::TraversalCode PreExpr(const zeek::detail::Expr* expr) override
{ {
if ( expr->Tag() != EXPR_NAME ) if ( expr->Tag() != EXPR_NAME )
return zeek::detail::TC_CONTINUE; return zeek::detail::TC_CONTINUE;

24
src/telemetry/Manager.cc
View file

@ -320,7 +320,7 @@ public:
void operator()(const broker::telemetry::metric_family_hdl* family, void operator()(const broker::telemetry::metric_family_hdl* family,
const broker::telemetry::dbl_counter_hdl* counter, const broker::telemetry::dbl_counter_hdl* counter,
broker::telemetry::const_label_list labels) broker::telemetry::const_label_list labels) override
{ {
if ( matches(family) ) if ( matches(family) )
metrics.emplace_back(MetricType::Counter, family, extract_label_values(labels), metrics.emplace_back(MetricType::Counter, family, extract_label_values(labels),
@ -329,7 +329,7 @@ public:
void operator()(const broker::telemetry::metric_family_hdl* family, void operator()(const broker::telemetry::metric_family_hdl* family,
const broker::telemetry::int_counter_hdl* counter, const broker::telemetry::int_counter_hdl* counter,
broker::telemetry::const_label_list labels) broker::telemetry::const_label_list labels) override
{ {
if ( matches(family) ) if ( matches(family) )
metrics.emplace_back(MetricType::Counter, family, extract_label_values(labels), metrics.emplace_back(MetricType::Counter, family, extract_label_values(labels),
@ -338,7 +338,7 @@ public:
void operator()(const broker::telemetry::metric_family_hdl* family, void operator()(const broker::telemetry::metric_family_hdl* family,
const broker::telemetry::dbl_gauge_hdl* gauge, const broker::telemetry::dbl_gauge_hdl* gauge,
broker::telemetry::const_label_list labels) broker::telemetry::const_label_list labels) override
{ {
if ( matches(family) ) if ( matches(family) )
metrics.emplace_back(MetricType::Gauge, family, extract_label_values(labels), metrics.emplace_back(MetricType::Gauge, family, extract_label_values(labels),
@ -347,7 +347,7 @@ public:
void operator()(const broker::telemetry::metric_family_hdl* family, void operator()(const broker::telemetry::metric_family_hdl* family,
const broker::telemetry::int_gauge_hdl* gauge, const broker::telemetry::int_gauge_hdl* gauge,
broker::telemetry::const_label_list labels) broker::telemetry::const_label_list labels) override
{ {
if ( matches(family) ) if ( matches(family) )
metrics.emplace_back(MetricType::Gauge, family, extract_label_values(labels), metrics.emplace_back(MetricType::Gauge, family, extract_label_values(labels),
@ -356,14 +356,14 @@ public:
void operator()(const broker::telemetry::metric_family_hdl* family, void operator()(const broker::telemetry::metric_family_hdl* family,
const broker::telemetry::dbl_histogram_hdl* histogram, const broker::telemetry::dbl_histogram_hdl* histogram,
broker::telemetry::const_label_list labels) broker::telemetry::const_label_list labels) override
{ {
// Ignored // Ignored
} }
void operator()(const broker::telemetry::metric_family_hdl* family, void operator()(const broker::telemetry::metric_family_hdl* family,
const broker::telemetry::int_histogram_hdl* histogram, const broker::telemetry::int_histogram_hdl* histogram,
broker::telemetry::const_label_list labels) broker::telemetry::const_label_list labels) override
{ {
// Ignored // Ignored
} }
@ -400,35 +400,35 @@ public:
void operator()(const broker::telemetry::metric_family_hdl* family, void operator()(const broker::telemetry::metric_family_hdl* family,
const broker::telemetry::dbl_counter_hdl* counter, const broker::telemetry::dbl_counter_hdl* counter,
broker::telemetry::const_label_list labels) broker::telemetry::const_label_list labels) override
{ {
// Ignored // Ignored
} }
void operator()(const broker::telemetry::metric_family_hdl* family, void operator()(const broker::telemetry::metric_family_hdl* family,
const broker::telemetry::int_counter_hdl* counter, const broker::telemetry::int_counter_hdl* counter,
broker::telemetry::const_label_list labels) broker::telemetry::const_label_list labels) override
{ {
// Ignored // Ignored
} }
void operator()(const broker::telemetry::metric_family_hdl* family, void operator()(const broker::telemetry::metric_family_hdl* family,
const broker::telemetry::dbl_gauge_hdl* gauge, const broker::telemetry::dbl_gauge_hdl* gauge,
broker::telemetry::const_label_list labels) broker::telemetry::const_label_list labels) override
{ {
// Ignored // Ignored
} }
void operator()(const broker::telemetry::metric_family_hdl* family, void operator()(const broker::telemetry::metric_family_hdl* family,
const broker::telemetry::int_gauge_hdl* gauge, const broker::telemetry::int_gauge_hdl* gauge,
broker::telemetry::const_label_list labels) broker::telemetry::const_label_list labels) override
{ {
// Ignored // Ignored
} }
void operator()(const broker::telemetry::metric_family_hdl* family, void operator()(const broker::telemetry::metric_family_hdl* family,
const broker::telemetry::dbl_histogram_hdl* histogram, const broker::telemetry::dbl_histogram_hdl* histogram,
broker::telemetry::const_label_list labels) broker::telemetry::const_label_list labels) override
{ {
if ( ! matches(family) ) if ( ! matches(family) )
return; return;
@ -452,7 +452,7 @@ public:
void operator()(const broker::telemetry::metric_family_hdl* family, void operator()(const broker::telemetry::metric_family_hdl* family,
const broker::telemetry::int_histogram_hdl* histogram, const broker::telemetry::int_histogram_hdl* histogram,
broker::telemetry::const_label_list labels) broker::telemetry::const_label_list labels) override
{ {
if ( ! matches(family) ) if ( ! matches(family) )
return; return;