Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 06:38:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Clean up initialization of DNS_Interpreter

Browse source
This commit is contained in:
Tim Wojtulewicz 2025-09-04 14:00:38 -07:00
parent 501160c976
commit f056df1301
2 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/analyzer/protocol/dns/DNS.cc
View file

@ -52,9 +52,7 @@ namespace detail {
// since it's similar to DNS but does some things differently.
constexpr int NETBIOS_PORT = 137;
DNS_Interpreter::DNS_Interpreter(analyzer::Analyzer* arg_analyzer) {
analyzer = arg_analyzer;
first_message = true;
DNS_Interpreter::DNS_Interpreter(analyzer::Analyzer* arg_analyzer) : analyzer(arg_analyzer) {
is_netbios =
ntohs(analyzer->Conn()->OrigPort()) == NETBIOS_PORT || ntohs(analyzer->Conn()->RespPort()) == NETBIOS_PORT;
}
@ -2185,8 +2183,6 @@ DNS_Analyzer::DNS_Analyzer(Connection* conn) : analyzer::tcp::TCP_ApplicationAna
DNS_Analyzer::~DNS_Analyzer() { delete interp; }
void DNS_Analyzer::Init() {}
void DNS_Analyzer::Done() {
analyzer::tcp::TCP_ApplicationAnalyzer::Done();

7
src/analyzer/protocol/dns/DNS.h
View file

@ -393,9 +393,9 @@ protected:
void SendReplyOrRejectEvent(detail::DNS_MsgInfo* msg, EventHandlerPtr event, const u_char*& data, int& len,
String* question_name, String* original_name);
analyzer::Analyzer* analyzer;
bool first_message;
bool is_netbios;
analyzer::Analyzer* analyzer = nullptr;
bool first_message = true;
bool is_netbios = false;
};
enum TCP_DNS_state : uint8_t {
@ -438,7 +438,6 @@ public:
void DeliverPacket(int len, const u_char* data, bool orig, uint64_t seq, const IP_Hdr* ip, int caplen) override;
void Init() override;
void Done() override;
void ConnectionClosed(analyzer::tcp::TCP_Endpoint* endpoint, analyzer::tcp::TCP_Endpoint* peer,
bool gen_event) override;