Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix policy/protocols/conn/failed-service-logging.zeek

Browse source 
In GH-4422 it was pointed out that the protocols/conn/failed-service-logging.zeek
policy script only works when
`DPD::track_removed_services_in_connection=T` is set.

This was caused by a logic error in the script. This commit fixes this
logic error and introduces an additional test that checks that
failed-service-logging works even when the option is not set to true.
This commit is contained in:
Johanna Amann 2025-05-06 13:37:12 +01:00
parent e986caddf0
commit f293d5a852
3 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
scripts/policy/protocols/conn/failed-service-logging.zeek
View file

@ -21,7 +21,7 @@ hook Analyzer::disabling_analyzer(c: connection, atype: AllAnalyzers::Tag, aid:
return;
# Only add if previously confirmed
if ( Analyzer::name(atype) !in c$service || Analyzer::name(atype) !in c$service_violation )
if ( Analyzer::name(atype) !in c$service && Analyzer::name(atype) !in c$service_violation )
return;
# Only log if dpd.zeek will disable