Remove a few protected or private no-op constructors

This commit is contained in:
Tim Wojtulewicz 2020-08-19 15:19:01 -07:00
parent 914a4d6342
commit f597e925aa
7 changed files with 5 additions and 15 deletions

View file

@ -401,7 +401,6 @@ public:
void Dispatch(double t, bool is_expire) override; void Dispatch(double t, bool is_expire) override;
protected: protected:
ConnectionTimer() = default;
void Init(Connection* conn, timer_func timer, bool do_expire); void Init(Connection* conn, timer_func timer, bool do_expire);

View file

@ -292,7 +292,6 @@ public:
void SetMaxOldBlocks(uint32_t count) { max_old_blocks = count; } void SetMaxOldBlocks(uint32_t count) { max_old_blocks = count; }
protected: protected:
Reassembler() { }
friend class DataBlockList; friend class DataBlockList;

View file

@ -65,7 +65,7 @@ public:
void Describe(ODesc* d) const; void Describe(ODesc* d) const;
protected: protected:
Timer() = default;
TimerType type{}; TimerType type{};
}; };

View file

@ -22,13 +22,12 @@ public:
void Dispatch(double t, bool is_expire) override; void Dispatch(double t, bool is_expire) override;
protected: protected:
AnalyzerTimer() : analyzer(), timer(), do_expire() {}
void Init(Analyzer* analyzer, analyzer_timer_func timer, int do_expire); void Init(Analyzer* analyzer, analyzer_timer_func timer, int do_expire);
Analyzer* analyzer; Analyzer* analyzer = nullptr;
analyzer_timer_func timer; analyzer_timer_func timer;
int do_expire; int do_expire = 0;
}; };
} // namespace zeek::analyzer } // namespace zeek::analyzer

View file

@ -82,7 +82,6 @@ public:
{ return seq + length <= seq_to_skip; } { return seq + length <= seq_to_skip; }
private: private:
TCP_Reassembler() { }
void Undelivered(uint64_t up_to_seq) override; void Undelivered(uint64_t up_to_seq) override;
void Gap(uint64_t seq, uint64_t len); void Gap(uint64_t seq, uint64_t len);

View file

@ -12,11 +12,6 @@ FileReassembler::FileReassembler(File *f, uint64_t starting_offset)
{ {
} }
FileReassembler::FileReassembler()
: zeek::Reassembler(), the_file(nullptr), flushing(false)
{
}
FileReassembler::~FileReassembler() FileReassembler::~FileReassembler()
{ {
} }

View file

@ -48,14 +48,13 @@ public:
{ return flushing; } { return flushing; }
protected: protected:
FileReassembler();
void Undelivered(uint64_t up_to_seq) override; void Undelivered(uint64_t up_to_seq) override;
void BlockInserted(zeek::DataBlockMap::const_iterator it) override; void BlockInserted(zeek::DataBlockMap::const_iterator it) override;
void Overlap(const u_char* b1, const u_char* b2, uint64_t n) override; void Overlap(const u_char* b1, const u_char* b2, uint64_t n) override;
File* the_file; File* the_file = nullptr;
bool flushing; bool flushing = false;
}; };
} // namespace analyzer::* } // namespace analyzer::*