Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-08 01:28:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

The Great Embooleanating

Browse source 
A large number of functions had return values and/or arguments changed
to use ``bool`` types instead of ``int``.
This commit is contained in:
Tim Wojtulewicz 2020-03-11 10:41:46 -07:00 • committed by Robin Sommer
parent 3c470ffe13
commit fd5e15b116
145 changed files with 1288 additions and 1331 deletions
Download patch file Download diff file Expand all files Collapse all files

22
src/analyzer/protocol/tcp/TCP_Endpoint.cc
View file

@ -14,7 +14,7 @@
using namespace analyzer::tcp;
TCP_Endpoint::TCP_Endpoint(TCP_Analyzer* arg_analyzer, int arg_is_orig)
TCP_Endpoint::TCP_Endpoint(TCP_Analyzer* arg_analyzer, bool arg_is_orig)
{
contents_processor = 0;
prev_state = state = TCP_ENDPOINT_INACTIVE;
@ -28,7 +28,7 @@ TCP_Endpoint::TCP_Endpoint(TCP_Analyzer* arg_analyzer, int arg_is_orig)
contents_start_seq = 0;
FIN_seq = 0;
SYN_cnt = FIN_cnt = RST_cnt = 0;
did_close = 0;
did_close = false;
contents_file = 0;
tcp_analyzer = arg_analyzer;
is_orig = arg_is_orig;
@ -75,7 +75,7 @@ void TCP_Endpoint::SetPeer(TCP_Endpoint* p)
sessions->tcp_stats.StateEntered(state, peer->state);
}
int TCP_Endpoint::HadGap() const
bool TCP_Endpoint::HadGap() const
{
return contents_processor && contents_processor->HadGap();
}
@ -90,20 +90,20 @@ void TCP_Endpoint::AddReassembler(TCP_Reassembler* arg_contents_processor)
contents_processor->SetContentsFile(contents_file);
}
int TCP_Endpoint::DataPending() const
bool TCP_Endpoint::DataPending() const
{
if ( contents_processor )
return contents_processor->DataPending();
else
return 0;
return false;
}
int TCP_Endpoint::HasUndeliveredData() const
bool TCP_Endpoint::HasUndeliveredData() const
{
if ( contents_processor )
return contents_processor->HasUndeliveredData();
else
return 0;
return false;
}
void TCP_Endpoint::CheckEOF()
@ -121,7 +121,7 @@ void TCP_Endpoint::SizeBufferedData(uint64_t& waiting_on_hole,
waiting_on_hole = waiting_on_ack = 0;
}
int TCP_Endpoint::ValidChecksum(const struct tcphdr* tp, int len) const
bool TCP_Endpoint::ValidChecksum(const struct tcphdr* tp, int len) const
{
uint32_t sum = checksum_base;
int tcp_len = tp->th_off * 4 + len;
@ -199,11 +199,11 @@ uint64_t TCP_Endpoint::Size() const
return size;
}
int TCP_Endpoint::DataSent(double t, uint64_t seq, int len, int caplen,
bool TCP_Endpoint::DataSent(double t, uint64_t seq, int len, int caplen,
const u_char* data,
const IP_Hdr* ip, const struct tcphdr* tp)
{
int status = 0;
bool status = false;
if ( contents_processor )
{
@ -267,7 +267,7 @@ void TCP_Endpoint::SetContentsFile(BroFile* f)
contents_processor->SetContentsFile(contents_file);
}
int TCP_Endpoint::CheckHistory(uint32_t mask, char code)
bool TCP_Endpoint::CheckHistory(uint32_t mask, char code)
{
if ( ! IsOrig() )
{