Commit graph

4693 commits

Author SHA1 Message Date
Jon Siwek
a316878d01 Add checks to avoid improper negative values use. 2013-09-17 16:42:48 -05:00
Daniel Thayer
0d68aad9b1 Merge remote-tracking branch 'origin/master' into topic/dnthayer/compilerwarn 2013-09-17 16:17:41 -05:00
Daniel Thayer
fdc0d5c7ec Fix compiler warning (time_t is not a pointer type) 2013-09-17 15:29:41 -05:00
Daniel Thayer
fdc364084b Fix cmake warning about ENABLE_PERFTOOLS not being used 2013-09-16 17:45:21 -05:00
Jon Siwek
a3b963ad4e Refactor Analyzer::AddChildAnalyzer and usages.
Make feedback available regarding whether adding a child analyzer fails
because one of the same type already exists (so one can avoid invalid
pointer access of a delete'd analyzer).
2013-09-16 16:20:55 -05:00
Jon Siwek
bb8f102b2c Minor refactor to SSL BinPAC grammer.
An unsized array already parses indefinitely.  &until($element <= 0)
just causes nonsense code to be generated.  I.e. checking a pointer that
can never even be null against <= 0.  And the compare would happen after
delete'ing the pointer, making it even odder (though still benign).
2013-09-16 16:10:49 -05:00
Jon Siwek
19b15217f0 Minor refactor to broxygen enum comments.
Coverity claimed a mismatched iterator here.  Don't think it was, but
this might make it either go away or make its insane template output
understandable.  Else at least it makes the code more readable.
2013-09-16 15:40:44 -05:00
Jon Siwek
c8758c4f24 Fix possible (unlikely) use of uninitialized value.
Plus two minor refactors/nits.
2013-09-16 15:36:18 -05:00
Bernhard Amann
ecc20b932a and const 2 more functions 2013-09-16 11:00:54 -07:00
Bernhard Amann
c0f780c728 update hll documentation, make a few functions private and create
a new copy constructor.
2013-09-16 10:40:25 -07:00
Daniel Thayer
1580fb5d61 Merge remote-tracking branch 'origin/master' into topic/dnthayer/compilerwarn 2013-09-16 11:21:00 -05:00
Daniel Thayer
20f11ad237 Fix another compiler warning 2013-09-16 11:20:07 -05:00
Bernhard Amann
eb1d7ccc4a Merge remote-tracking branch 'origin/master' into topic/bernhard/ticket1072 2013-09-16 09:15:24 -07:00
Jon Siwek
735d2c402a Fix/improve dereference-before-null-checks. 2013-09-13 16:41:41 -05:00
Jon Siwek
3d81432a1e Fix out-of-bounds memory accesses.
And remove a variable-length-array usage.
2013-09-13 15:05:17 -05:00
Jon Siwek
5a992879a0 Fix potential mem leak. 2013-09-13 14:31:03 -05:00
Jon Siwek
a99e873d5c Fix double-free and deallocator mismatch. 2013-09-13 14:30:22 -05:00
Jon Siwek
33a7e96268 Fix another function val reference counting bug.
Now that functions get unref'd in the val dtor in order to free mem of
unserialized functions, it's important to ref a function when creating a
val from a pre-existing function so it's not prematurely free'd.
2013-09-13 12:51:24 -05:00
Daniel Thayer
1d33883dfc Fix compiler warnings 2013-09-13 00:30:18 -05:00
Jon Siwek
bcf79fe11a Merge branch 'topic/dnthayer/doc-fix-links'
BIT-1076 #merged
2013-09-12 16:40:28 -05:00
Jon Siwek
c9d44788f6 Merge branch 'fastpath' 2013-09-12 16:00:09 -05:00
Jon Siwek
0b97343ff7 Fix various potential memory leaks.
Though I expect most not to be exercised in practice.
2013-09-12 15:23:52 -05:00
Jon Siwek
801f32c8ee Updating submodule(s).
[nomail]
2013-09-12 12:33:24 -05:00
Daniel Thayer
b02709f88f Fix broken links in the documentation
Also removed a duplicate link under "Script Reference".
2013-09-11 16:32:02 -05:00
Bernhard Amann
9834755948 fix case where hll_error_margin could be undefined (thanks John) 2013-09-11 12:50:29 -07:00
Bernhard Amann
c40a97156a make client and server random available on script-level.
Patch by ewust

Addresses BIT-950
2013-09-11 12:39:23 -07:00
Jon Siwek
c3a4454892 Fix significant memory leak.
Particularly, unserializing a function is frequent and leaked.
2013-09-10 16:10:10 -05:00
Jon Siwek
1fbeefedbc Fix two use-after-free bugs. 2013-09-10 13:30:23 -05:00
Daniel Thayer
ee1312f2ad Fix an error seen when building documentation 2013-09-10 11:22:14 -05:00
Seth Hall
7c1dffa66f Fixed an issue with the HLL_UNIQUE SumStats plugin that caused a reporter error. 2013-09-06 15:31:00 -04:00
Jon Siwek
b76d8eedbb Updating submodule.
[nomail]
2013-09-05 16:54:53 -05:00
Jon Siwek
a9a245e017 Workaround type ambiguity w/ default record field. 2013-09-05 16:41:51 -05:00
Jon Siwek
aed9943c95 Merge branch 'master' into fastpath 2013-09-05 16:33:03 -05:00
Jon Siwek
0b5a75a463 Fix mem leak in failing table initialization case.
Specifically that case looked like tables that have a compound index
and an element assignment fails due to a type mismatch.
2013-09-05 16:09:52 -05:00
Jon Siwek
f823b92e5e Fix mem leak when merging incompatible types.
Though this would typically be caused by a scripting error that should
be fixed and Bro would exit anyway if encountered at parse time.
2013-09-05 15:47:57 -05:00
Jon Siwek
75d469532c Fix mem leak when unserializing table entry fails.
Shouldn't happen in practice.
2013-09-05 15:40:10 -05:00
Jon Siwek
766cc0d220 Fix mem leak when failing to end a serialization.
We'd probably know about it if that actually ever happened in practice
(which it shouldn't).
2013-09-05 15:30:28 -05:00
Jon Siwek
703ef3b908 Fix mem leak when unserializing an arg in a function call fails.
Shouldn't be a typical scenario since hopefully we'd know about
and fix the underlying problem w/ unserialization...
2013-09-05 15:09:05 -05:00
Jon Siwek
4e8ba6eaa2 Fix signatures that use identifiers of type table. 2013-09-05 13:01:40 -05:00
Jon Siwek
eef432561e Fix memory leak if a DNS request fails to be made.
A symptom of this is a "can't issue DNS request" warning in
reporter.log. (Doesn't look like this should be a typical thing
that happens in most environments).
2013-09-05 11:52:40 -05:00
Seth Hall
ef50802fd7 Make the notice $actions field have a default empty set to avoid having to check for it's presence. 2013-09-05 12:07:21 -04:00
Jon Siwek
7799a86a7f Adjust HLL cluster leak test so leaks trigger a failure. 2013-09-04 16:53:58 -05:00
Jon Siwek
3939b629ae Adjust DNS memory leak test to actually fail if there's a leak. 2013-09-04 16:49:04 -05:00
Jon Siwek
62de5678f7 Fix memory leak in DNS TXT lookups. 2013-09-04 16:47:44 -05:00
Jon Siwek
6ad82ff263 Fix invalid/mismatched deallocators. 2013-09-04 14:45:09 -05:00
Jon Siwek
f9dc48e573 Fix logging filter over-allocation and leak.
The leak could happen in a couple cases where adding a log filter
fails: OOM and unsupported field type.
2013-09-04 14:25:57 -05:00
Jon Siwek
0678468353 Internal UID simplifications/nits. 2013-09-04 11:46:53 -05:00
Jon Siwek
ca9b9162a7 Fix raw execution input reader's signal blocking.
Signals are generally blocked within threads in Bro so that the main
thread does all signal handling, however, signal masks are inherited
over fork() and exec(), so they should be unblocked before exec() so
that process can respond to signals normally.

This fixes the raw reader from leaving behind processes that didn't
respond to SIGTERM at shutdown because it was blocked before exec().
2013-09-04 10:45:29 -05:00
Jon Siwek
db470a637a Documentation fixes.
This cleans up most of the warnings from sphinx (broken :doc: links,
broxygen role misuses, etc.).  The remaining ones should be harmless,
but not quick to silence.

I found that the README for each component was a copy from the actual
repo, so I turned those in to symlinks so they don't get out of date.
2013-09-03 15:59:40 -05:00
Robin Sommer
2392a29b7f Redoing doc.sphinx baselines. 2013-08-31 18:10:09 -07:00