* origin/topic/johanna/1095-just-get-rid-of-it:
Re-add TYPE_COUNTER without function and deprecation marker.
Completely remove all traces of the COUNTER type.
* origin/topic/timw/266-namespaces-part3: (24 commits)
Properly forward-declare zeek::plugin::plugin in DebugLogger
Rename Brofiler to ScriptCoverageManager
Move Conn and related types to zeek namespace
Move reassembler code to namespaces
Move Session code to namespaces
Move ODesc to zeek namespace
Move Stats and related classes to zeek::detail
Move a few low-use classes to namespaces
Move DebugLogger to zeek namespaces
Move all of the hashing classes/functions to zeek::detail namespace
Move all of the Packet-related classes to namespaces
Move EventMgr, EventHandler, and EventRegistry code to zeek namespace. Rename mgr to event_mgr.
Move Timer and PriorityQueue classes to namespaces
Move BroFile to zeek namespace, rename to File
Move Reporter to zeek namespace
Move DNS_Mgr to zeek::detail namespace
Move BroSubstring to zeek::detail, rename to Substring
Move regex matching code to zeek namespaces
Move all of the rule matching code to zeek::detail
Move IP Addr/Prefix/Header classes into namespaces
...
E.g. defining a `Foo::RED` enum name when a `GLOBAL::RED` identifier
already exists would previously be treated as an error, even though the
names don't truly conflict.
``NetControl::DROP`` had 3 conflicting definitions that could potentially
be used incorrectly without any warnings or type-checking errors.
Such enum redefinition conflicts are now caught and treated as errors,
so the ``NetControl::DROP`` enums had to be renamed:
* The use as enum of type ``Log::ID`` is renamed to ``NetControl::DROP_LOG``
* The use as enum of type ``NetControl::CatchReleaseInfo`` is renamed to
``NetControl::DROP_REQUESTED``
* The use as enum of type ``NetControl::RuleType`` is unchanged and still
named ``NetControl::DROP``
* origin/topic/timw/clang-tidy:
Don't specify 0u for initial value of loops changed to size_t
Use .empty() instead of checking size against zero
Use properly-sized loop variables or convert to ranged-for (bugprone-too-small-loop-variable)
Merge changes one type over to ptrdiff_t
