Coverity has trouble analyzing them and they're contributing to
bringing the overall successfully-analyzed-compilation-unit ratio
below the required 85%.
- Minor adjustments to header includes, whitespace, and a
compiler warning fix during merge
* origin/topic/neverlord/gh-1408:
Add new Timer class to the telemetry API
Fix build with latest VectorVal API
Update baselines
Prefix telemetry BIFs with __
Expose telemetry API to scripting land
Add handle types for histogram metrics
Move duplicated code to detail header
Adhere to Zeek coding style
Apply suggestions from code review
Add telemetry Manager to Zeek setup / teardown
Add missing whitespaces for Zeek coding style
Add gauge metric types
Add scaffold for new metrics API with counters
* origin/topic/vern/cpp-prep-profiling:
Add missing errno include to ProfileFunc.cc
Adjust GetAttrs() usage in ProfileFunc::PreExpr() to const-reference
Fix whitespace in ProfileFunc::PreExpr()
Avoid redundant map/set searches in various ProfileFunc methods
Improve detail::script_specific_filename()
Use std::string_view in p_hash() to avoid string copies
function profiling rewritten - more detailed info, supports global profiling
track whether a given function/body should be included/skipped for optimization
* origin/topic/vern/global-stmts:
whitespace adjustment
"balance" tests with multiple Zeek scripts to load the same elements
put global statements into a quasi-function to support script optimization
* origin/topic/jsiwek/misc-val-tweaks:
Fix sign-compare compiler warning in coerce_to_record()
Fix maybe-uninitialized warning in ZVal::ToVal()
Change RecordVal::GetFieldAs() to use std::vector::operator[]
Add RecordVal::AssignField() and use it in supervisor code
- Restored a deprecated version of 'supervisor_rotation_format_func'
during merge.
* origin/topic/vlad/expose_supervisor_rotation_func:
Rename supervisor_rotation_format_func to archiver_rotation_format_func, and expose it for non-supervised setups
* origin/topic/vern/cpp-prep-factoring:
test suite update due to factoring out coerce_to_record()
removal of vestigial #include's (breaking an include loop in the process)
better method name: HasCopySemantics()
Use STL functionality to initialize coercion map
comments for factored-out index slice functions
support for subclassing ScriptFunc's, esp. for alternate lambda closures
factor out record coercion; modernize management of coercion "map"
lower-level method for adding fields to records
factor out "print" statement's execution functionality
functions for indexing slices and strings
new function for getting the location, if any, associated with the current call
- Removed a couple of dead statements during merge
* origin/topic/vern/cpp-new-func:
option for deterministic descriptions of sets & tables
determinism for concurrent Zeek test suite invocations; split out deprecations
disambiguate descriptions of enums; include attributes when describing records
more liberal view of attribute equality; allow suppressing attr type-checking
support for operations on sets that return new values
low-level addition of enum values
sundry accessors/cast-ers; RE_Matcher's track their construction values
convenience functions for comparing IP addresses
- During merge, simplified the API docs for Analyzer::DeleteChild()
(found it unclear/unnecessary to refer to any `std` container types)
* origin/topic/timw/analyzer-iterators:
Clean up iterator usage in Analyzer
* origin/topic/vern/cpp-prep-fixes:
fix for associating current scope with the name of enums; name tidying
avoid infinite recursion in same_type() if it is analyzing recursive types
remove iffy reliance on type punning that relies on interpreter's behavior
fixes for propagating optimization options, and pruning script function analysis
- Removed a stray `printf()` from script-opt Reduce code
* origin/topic/vern/ast-opt: (23 commits)
Tweak minor const-ref/std::move things in script-opt code
Add alternative 'xform' baseline for test: broker.store.create-failure
Add explicit return value to Reducer::SameOp()
fixed AST transformation logic for boolean expressions
don't know how I overlooked these minor test suite updates
"opt" btest baseline updates due to AST optimizations changing printed code
"opt" baseline exceptions due to incompatibility with optimize-AST and -u
new "opt" btest alternative
update to "xform" test suite baseline due to recent line number changes
logic for driving AST optimization when requested
methods implementing AST optimization (aliasing, constant propagation, CSE)
helper class checking if common-subexpression elimination opportunity is valid
helper function for comparing collections of definition points
track more information about temporary variables
simplify and tidy up some interfaces
enable setting "-O optimize-AST" option
fix for reducing operations on boolean vectors
control whether checking for type-equivalence generates warnings
remove unneeded virtual method (same as inherited method)
accessors for additional Expr subclasses
...
* 'topic/keithjjones/openvpn' of https://github.com/keithjjones/zeek:
Replace assert with if statement so OpenVPN can use this over UDP. And fix spelling.
- Applied minor spelling/grammar suggestions from Johanna during merge
* origin/topic/jsiwek/zeekygen-code-links:
Change update-zeekygen-docs.sh to set release branch in Sphinx config
Teach Zeekygen to produce source-code-range information
Add normalize_script_path() zeek::zeekygen::detail namespace
Add starts_with()/ends_with() to zeek::util namespace
* origin/topic/jsiwek/coverity-lint:
Avoid superfluous string copies when adding to zeek::detail::sig_files
Initialize an RD_Decorate member via std::move
Fix invalid iterator comparison in UseDefs::FindSuccUsage()
- Added explicit test case of "unused assignement" warning and
&is_used suppression during merge.
* origin/topic/vern/use-defs:
activate &is_used
removed unnecessary statement flagged by Coverity (thanks, Jon!)
Adjust reference/move nitpicks in use-def/reduce code
Adjust some whitespace in UseDefs.cc
updates to "usage" test suite alternative now that more warnings are generated
suppress usage warning in baseline script
"xform" alternative baseline update, needed for recent change to master
baseline update due to shift in number of lines in base intel framework script
environment variable (which has precedence) not flags for baseline usage test
splitting out "usage" test suite alternative into -u/-uu versions
adding &is_used attribute for base scripts - not actually needed yet, but will be once optimization is added
removing unused assignments from base scripts
driver glue for invoking use-def construction
classes for managing and propagating use-defs
enhancements/changes to the Reduce class in preparation for use-defs
some tidying with smart pointers
flag/environment variable for dumping use-defs
&is_used attribute to suppress set-but-not-used usage warnings
whitespace micro-preening
