Commit graph

11716 commits

Author SHA1 Message Date
Jon Siwek
b66f4ad500 Tweak minor const-ref/std::move things in script-opt code 2021-03-08 15:50:04 -08:00
Jon Siwek
4b6369a333 Add alternative 'xform' baseline for test: broker.store.create-failure 2021-03-08 12:59:30 -08:00
Jon Siwek
0ef315d143 Add explicit return value to Reducer::SameOp()
Helps tools that don't realize the implications of [[noreturn]] on
the Reporter::InternalError() in this case.
2021-03-08 12:39:39 -08:00
Jon Siwek
75d3cbda4b Merge branch 'master' into topic/vern/ast-opt 2021-03-08 12:35:04 -08:00
Jon Siwek
285aaa53d7 Merge remote-tracking branch 'origin/topic/jsiwek/improve-broker-store-creation'
* origin/topic/jsiwek/improve-broker-store-creation:
  GH-1426: Improve handling of Broker data store creation failures
2021-03-08 12:29:56 -08:00
Johanna Amann
358d82eb38 Merge branch 'topic/keithjjones/openvpn' of https://github.com/keithjjones/zeek
* 'topic/keithjjones/openvpn' of https://github.com/keithjjones/zeek:
  Replace assert with if statement so OpenVPN can use this over UDP.  And fix spelling.
2021-03-08 11:25:32 +00:00
Jon Siwek
6af436aad3 GH-1426: Improve handling of Broker data store creation failures
Broker::create_master() and Broker::create_clone() now return
a valid value even when there's a failure to open the backend database
(e.g. SQLite filesystem error).  In that case, the returned value can
still be passed into other data store operations, but they'll fail
immediately with an error.  Broker::is_closed() can now also be used to
determine whether the data store creation calls failed.
2021-03-06 02:32:29 -08:00
Jon Siwek
6946cffde2 Simplify some copy_string() usages in threading::Field 2021-03-05 17:38:36 -08:00
Jon Siwek
ff90236df3 Merge remote-tracking branch 'origin/topic/timw/lgtm'
- Fixed leak in threading::Field copy-assignment operator

* origin/topic/timw/lgtm:
  Use const-reference in plugin::Manager::MetaHookPost for minor performance gain
  Fix missing assigmnent operator/copy constructor pairings reported by LGTM
  Fix variable shadowing issues reported by LGTM
  Update binpac and broker submodules to fix LGTM findings
2021-03-05 17:28:05 -08:00
Jon Siwek
e41edf78bc Update submodule(s) [nomail] [skip ci] 2021-03-05 16:42:45 -08:00
Jon Siwek
5f7fc043de Merge remote-tracking branch 'origin/topic/christian/canonicalize-zeek-config-includes'
* origin/topic/christian/canonicalize-zeek-config-includes:
  Avoid reporting paths repeatedly in zeek-config --include_dir
2021-03-05 16:14:37 -08:00
Jon Siwek
f5527b5dca Update submodule(s) [nomail] [skip ci] 2021-03-05 16:00:42 -08:00
Keith Jones
6fa02a7db4 Replace assert with if statement so OpenVPN can use this over UDP. And fix spelling. 2021-03-05 10:53:46 -05:00
Christian Kreibich
ca725c1f9b Avoid reporting paths repeatedly in zeek-config --include_dir 2021-03-04 15:40:00 -08:00
Tim Wojtulewicz
0d62ed4783 Use const-reference in plugin::Manager::MetaHookPost for minor performance gain 2021-03-03 10:29:25 -07:00
Tim Wojtulewicz
51f17534d4 Fix missing assigmnent operator/copy constructor pairings reported by LGTM 2021-03-03 10:29:25 -07:00
Tim Wojtulewicz
2f2a265415 Fix variable shadowing issues reported by LGTM 2021-03-03 09:57:16 -07:00
Tim Wojtulewicz
59b40168fb Update binpac and broker submodules to fix LGTM findings 2021-03-03 09:53:08 -07:00
Tim Wojtulewicz
5111b8e386 Fix comment in IP analyzer 2021-03-02 14:04:30 -07:00
Jon Siwek
bca8c3053b Update submodule(s) [nomail] [skip ci] 2021-03-02 12:47:34 -08:00
Vern Paxson
1e316c05c9 fix some unsigned/signed integer warnings 2021-03-01 17:08:14 -08:00
Vern Paxson
602d8a5372 address lint concern about uninitialized variable 2021-03-01 17:08:06 -08:00
Tim Wojtulewicz
150ba6443e Remove use of obsolete forward-declaration macros 2021-03-01 15:43:17 -07:00
Jon Siwek
e2d2c75fe7 Merge remote-tracking branch 'origin/topic/jsiwek/zeekygen-code-links'
- Applied minor spelling/grammar suggestions from Johanna during merge

* origin/topic/jsiwek/zeekygen-code-links:
  Change update-zeekygen-docs.sh to set release branch in Sphinx config
  Teach Zeekygen to produce source-code-range information
  Add normalize_script_path() zeek::zeekygen::detail namespace
  Add starts_with()/ends_with() to zeek::util namespace
2021-03-01 11:37:29 -08:00
Vern Paxson
2ec8b065cc Merge branch 'topic/vern/zval' of github.com:zeek/zeek into topic/vern/zval 2021-02-28 07:23:58 -08:00
Vern Paxson
526ba54f15 fix #include's that lack zeek/ prefixes 2021-02-28 07:23:06 -08:00
Vern Paxson
6aab151d97 explicitly populate holes created in vectors 2021-02-28 07:23:06 -08:00
Vern Paxson
2f47cce8a6 fixes for now-incorrect assumption that GetField always returns an existing ValPtr 2021-02-28 07:23:06 -08:00
Vern Paxson
3a59bc1a37 memory management for assignment to vector elements 2021-02-28 07:22:40 -08:00
Vern Paxson
7adcd1b27b memory management for assignment to record fields 2021-02-28 07:22:31 -08:00
Vern Paxson
498d8c4bde destructor cleanup from ZAM_vector/ZAM_record 2021-02-28 07:22:18 -08:00
Vern Paxson
679ee6ce22 fix #include's that lack zeek/ prefixes 2021-02-27 17:00:37 -08:00
Vern Paxson
a82a0e22d8 fixed AST transformation logic for boolean expressions 2021-02-27 13:48:06 -08:00
Vern Paxson
9496379b95 don't know how I overlooked these minor test suite updates 2021-02-27 13:47:49 -08:00
Vern Paxson
0f10c46f42 overlooked another way in which vector holes can be created 2021-02-27 13:34:53 -08:00
Vern Paxson
f43be3a206 initialize vector holes to the correct corresponding type 2021-02-27 12:06:02 -08:00
Vern Paxson
9953961569 "opt" btest baseline updates due to AST optimizations changing printed code 2021-02-27 11:43:17 -08:00
Vern Paxson
4847c357ca "opt" baseline exceptions due to incompatibility with optimize-AST and -u 2021-02-27 11:42:24 -08:00
Vern Paxson
8f21432f76 new "opt" btest alternative 2021-02-27 11:41:23 -08:00
Vern Paxson
42d59203a1 update to "xform" test suite baseline due to recent line number changes 2021-02-27 11:40:33 -08:00
Vern Paxson
faf1b65ec4 logic for driving AST optimization when requested 2021-02-27 11:39:44 -08:00
Vern Paxson
77f04935a8 methods implementing AST optimization (aliasing, constant propagation, CSE) 2021-02-27 11:36:15 -08:00
Vern Paxson
34ccd3e417 helper class checking if common-subexpression elimination opportunity is valid 2021-02-27 11:35:01 -08:00
Vern Paxson
ec97c9b042 helper function for comparing collections of definition points 2021-02-27 11:32:06 -08:00
Vern Paxson
b581c6435e track more information about temporary variables 2021-02-27 11:08:34 -08:00
Vern Paxson
64ef7f0eb2 simplify and tidy up some interfaces 2021-02-27 11:07:39 -08:00
Vern Paxson
d38cc04e83 enable setting "-O optimize-AST" option 2021-02-27 10:59:27 -08:00
Vern Paxson
56ab0ddcf1 fix for reducing operations on boolean vectors 2021-02-27 10:57:25 -08:00
Vern Paxson
c7234713b1 control whether checking for type-equivalence generates warnings 2021-02-27 10:55:19 -08:00
Vern Paxson
588fcce7df explicitly populate holes created in vectors 2021-02-27 10:54:11 -08:00