This reverts part of commit a0888b7e36 due
to inhibiting analyzer violations when parsing non SSH traffic when
the &restofdata path is entered.
@J-Gras reported the analyzer not being disabled when sending HTTP
traffic on port 22.
This adds the verbose analyzer.log baselines such that future improvements
of these scenarios become visible.
We move the current `TypeMismatch` into a new `ParameterMismatch`
exception that's derived from a more general `TypeMismatch` now that
can also be used for other, non-parameter mismatches.
* origin/topic/christian/ci-updates:
CMakeLists: Disable -Werror for 3rdparty/sqlite3.c
Bump zeek-3rdparty to pull in sqlite move to 3.46
CI: drop Fedora 38, add 40
We package vanilla sqlite from upstream and on Fedora 40 with sqlite 3.46
there's the following compiler warning:
In function 'sqlite3Strlen30',
inlined from 'sqlite3ColumnSetColl' at
../../src/3rdparty/sqlite3.c:122105:10:
../../src/3rdparty/sqlite3.c:35003:28: error: 'strlen' reading 1 or more bytes from a region of size 0 [-Werror=stringop-overread]
35003 | return 0x3fffffff & (int)strlen(z);
| ^~~~~~~~~
In function 'sqlite3ColumnSetColl':
Disabling -Werror on sqlite3.c seems sensible given we have little
control over that code.
We now reject EVT files that attempt to replace the same built-in
analyzer multiple times as doing so would be ill-defined and not very
intuitive in what exactly it means.
Closes#3783.
When CCACHE_BASEDIR is set, ccache will rewrite absolute paths to
relative paths in order to allow compilation in different source
directories. We do not need this feature on Cirrus (the checkout
is always in /zeek) and using absolute paths avoids
confusion/normalization needs for the gcov -p results.
We could consider removing the global CCACHE_BASEDIR, but it'd
bust the ccache of every other task, too.
* origin/topic/timw/telemetry-follow-up:
Switch to zeek fork of prometheus-cpp
Remove unnecessary shared_from_this on instrument classes
Restore label_names field in MetricOpts record
Change how we count FDs on Linux to fix zeekctl stop issues
Update zeekctl tests for telemetry rework
Use forward declarations of prometheus-cpp types in telemetry::Manager
Add prometheus-cpp files to install set for plugins to use
Fix a memory leak with the CivetWeb callbacks in telemetry
Fix a bunch of copy-instead-of-move findings from Coverity
Move telmetry label names out of opts records, into main metric records
Ensure the order of label values matches the label names
Remove prefix column from telemetry.log
Fix race condition by pre-building the cluster json data for services.json
Set running_under_test for scripts.base.frameworks.logging.telemetry test
* origin/topic/vern/script-opt-maint.Jun24:
script optimization baseline tweaks due to recent minor changes
updated list of BiFs for script optimization
addressed some Coverity nits
improved error cascade for invalid attributes
