Tim Wojtulewicz
bc4cf14237
CI: Add PR label for skipping all CI jobs
2025-05-30 10:29:02 -07:00
Tim Wojtulewicz
e9544386fe
CI: Add PR label for running cluster tests
2025-05-30 10:27:52 -07:00
Vern Paxson
dc68a62a1e
fix for crash when interpreting transformed ASTs that include multi-field record assignments/additions
2025-05-30 09:44:26 -07:00
Vern Paxson
ba0b7492a7
Remove unused ZAM compiler method
2025-05-30 09:38:42 -07:00
Tim Wojtulewicz
9c290df47f
Merge remote-tracking branch 'origin/topic/timw/ci-clang-tidy'
...
* origin/topic/timw/ci-clang-tidy:
CI: Add new task to run clang-tidy as part of nightly builds
CI: Update to clang 19 on ubuntu 24.04, add clang-tidy package
2025-05-30 08:39:36 -07:00
Tim Wojtulewicz
bf9813a7c6
CI: Add new task to run clang-tidy as part of nightly builds
2025-05-30 08:39:14 -07:00
Tim Wojtulewicz
dbd787a81f
CI: Update to clang 19 on ubuntu 24.04, add clang-tidy package
2025-05-30 08:39:14 -07:00
Arne Welzel
f4cd92e24a
Merge remote-tracking branch 'origin/topic/awelzel/4494-ts-millis-signed'
...
* origin/topic/awelzel/4494-ts-millis-signed:
logging/ascii/json: Make TS_MILLIS signed, add TS_MILLIS_UNSIGNED
2025-05-30 17:24:17 +02:00
Arne Welzel
93813a5079
logging/ascii/json: Make TS_MILLIS signed, add TS_MILLIS_UNSIGNED
...
It seems TS_MILLIS is specifically for Elasticsearch and starting with
Elasticsearch 8.2 epoch_millis does (again?) support negative epoch_millis,
so make Zeek produce that by default.
If this breaks a given deployment, they can switch Zeek back to TS_MILLIS_UNSIGNED.
https://discuss.elastic.co/t/migration-from-es-6-8-to-7-17-issues-with-negative-date-epoch-timestamp/335259
https://github.com/elastic/elasticsearch/pull/80208
Thanks for @timo-mue for reporting!
Closes #4494
2025-05-30 17:23:29 +02:00
Tim Wojtulewicz
c387ec87be
Merge remote-tracking branch 'origin/topic/timw/clang-tidy-performance-fixes'
...
* origin/topic/timw/clang-tidy-performance-fixes:
Add move operations for LogWriteHeader
Add missing setting of type in session::Key move operations
Update .clang-tidy to have performance-* enabled with some exclusions
Fix clang-tidy performance-inefficient-string-concatenation warnings
Fix clang-tidy performance-unnecessary-copy-initialization warnings
Fix clang-tidy performance-move-const-argument warnings (not move assignable/copyable)
Fix clang-tidy performance-move-const-argument warnings (passing move to const argument)
Fix clang-tidy performance-move-const-argument warnings (moving trivially copyable)
Fix clang-tidy performance-move-const-argument warnings (moving const variables)
Fix clang-tidy performance-inefficient-vector-operation warnings
Fix clang-tidy performance-for-range-copy warnings
Fix clang-tidy performance-faster-string-find warnings
Fix clang-tidy performance-enum-size warnings
Fix clang-tidy performance-avoid-endl warnings
2025-05-30 08:13:19 -07:00
Tim Wojtulewicz
6eb49a10cc
Add move operations for LogWriteHeader
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
df852255c6
Add missing setting of type in session::Key move operations
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
db69773d23
Update .clang-tidy to have performance-* enabled with some exclusions
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
c609d5c90a
Fix clang-tidy performance-inefficient-string-concatenation warnings
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
cb8c35748a
Fix clang-tidy performance-unnecessary-copy-initialization warnings
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
909413838c
Fix clang-tidy performance-move-const-argument warnings (not move assignable/copyable)
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
57c10a6ace
Fix clang-tidy performance-move-const-argument warnings (passing move to const argument)
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
ad4694f529
Fix clang-tidy performance-move-const-argument warnings (moving trivially copyable)
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
144a3dee3a
Fix clang-tidy performance-move-const-argument warnings (moving const variables)
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
6196950567
Fix clang-tidy performance-inefficient-vector-operation warnings
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
b8e28abb97
Fix clang-tidy performance-for-range-copy warnings
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
178d7f4cd0
Fix clang-tidy performance-faster-string-find warnings
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
f4c47d0357
Fix clang-tidy performance-enum-size warnings
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
11a1d8d506
Fix clang-tidy performance-avoid-endl warnings
2025-05-30 08:02:55 -07:00
Arne Welzel
10bfb34a8a
Update doc submodule [nomail] [skip ci]
...
Fix botched last-minute cleanup.
2025-05-30 16:49:10 +02:00
Arne Welzel
1d241fabf4
Merge remote-tracking branch 'origin/topic/awelzel/zeekygen-field-directive'
...
* origin/topic/awelzel/zeekygen-field-directive:
Bump doc submodule for ext/zeek.py modifications
RecordType:DescribeReST: Render RecordType using zeek:field directive
2025-05-30 16:44:42 +02:00
Arne Welzel
f16ebd34b3
Merge remote-tracking branch 'origin/topic/awelzel/4474-cluster-websocket-ipv6'
...
* origin/topic/awelzel/4474-cluster-websocket-ipv6:
IXWebsocket: Bump to version with memset() sock addr fix
cluster/websocket: Deprecate $listen_host, introduce $listen_addr
cluster/websocket-ixwebsocket: Determine proper address_family
2025-05-30 11:47:55 +02:00
Arne Welzel
66fef5a9bd
IXWebsocket: Bump to version with memset() sock addr fix
2025-05-30 11:02:41 +02:00
Arne Welzel
544d571089
cluster/websocket: Deprecate $listen_host, introduce $listen_addr
...
This only changes the script-layer API, but keeps the std::string host
in the C++ layer's ServerOptions. Mostly because the ixwebsocket library
takes host as std::string. Also, maybe at some point we'd want to
support something scheme-based like unix:///var/run/zeek.sock and placing
that in a string could not be totally wrong.
Add tests for IPV6, too.
2025-05-30 11:02:41 +02:00
Arne Welzel
8b029d0050
cluster/websocket-ixwebsocket: Determine proper address_family
...
Closes #4474
2025-05-30 11:01:31 +02:00
Tim Wojtulewicz
372986f052
Update docs submodue [nomail] [skip ci]
2025-05-28 11:44:09 -07:00
Tim Wojtulewicz
2d7aad2c81
Merge remote-tracking branch 'origin/topic/timw/remove-with-bind'
...
* origin/topic/timw/remove-with-bind:
Remove obsolete --with-bind configure flag
2025-05-28 08:29:50 -07:00
Arne Welzel
871e81dd6a
Bump doc submodule for ext/zeek.py modifications
2025-05-28 16:18:44 +02:00
Arne Welzel
71fb301e3d
RecordType:DescribeReST: Render RecordType using zeek:field directive
...
This is for zeek/zeek-docs#324 .
2025-05-28 15:59:50 +02:00
Robin Sommer
e494fb5d19
Bump Spicy to pull in fix.
...
Includes a new regression test.
Closes #4501 .
2025-05-28 15:50:47 +02:00
Tim Wojtulewicz
9db9861f75
Remove obsolete --with-bind configure flag
2025-05-27 17:55:49 -07:00
zeek-bot
9ffc87a90e
Update doc submodule [nomail] [skip ci]
2025-05-28 00:38:27 +00:00
Tim Wojtulewicz
88ae3ba412
Merge remote-tracking branch 'origin/topic/timw/coverity'
...
* origin/topic/timw/coverity:
Add a few std::moves to fix Coverity warnings
Fix possible memory leak in broker::Manager
fixup! Use SCN* constants when reading into sized integer types
from_json: Statically lookup err index in result type
Use SCN* constants when reading into sized integer types
Remove setting unused variable value in FTP::parse_eftp
2025-05-27 12:49:13 -07:00
Tim Wojtulewicz
e4ab1a3b1d
Add a few std::moves to fix Coverity warnings
2025-05-27 12:03:45 -07:00
Tim Wojtulewicz
ff7c908460
Fix possible memory leak in broker::Manager
2025-05-27 12:03:45 -07:00
Tim Wojtulewicz
54c5a470bd
fixup! Use SCN* constants when reading into sized integer types
2025-05-27 12:03:45 -07:00
Tim Wojtulewicz
a6437142ce
from_json: Statically lookup err index in result type
2025-05-27 12:03:45 -07:00
Tim Wojtulewicz
1992a55798
Use SCN* constants when reading into sized integer types
2025-05-27 12:03:45 -07:00
Tim Wojtulewicz
ff4d1a4121
Remove setting unused variable value in FTP::parse_eftp
2025-05-27 12:03:45 -07:00
Tim Wojtulewicz
aaca36dc22
Merge remote-tracking branch 'origin/topic/timw/clang-tidy-bugprone-fixes'
...
* origin/topic/timw/clang-tidy-bugprone-fixes: (22 commits)
Update .clang-tidy to have bugprone-* enabled with some exclusions
Fix clang-tidy bugprone-unused-return-value warnings
Fix clang-tidy bugprone-unsafe-functions warnings
Fix clang-tidy bugprone-unused-local-non-trivial-variable warnings
Fix clang-tidy bugprone-throw-keyword-missing warnings
Fix clang-tidy bugprone-switch-missing-default-case warnings
Fix clang-tidy bugprone-suspicious-realloc-usage warnings
Fix clang-tidy bugprone-suspicious-include warnings
Fix clang-tidy bugprone-suspicious-string-compare warnings
Fix clang-tidy bugprone-suspicious-stringview-data-usage warnings
Fix clang-tidy bugprone-string-literal-with-embedded-nul warnings
Fix clang-tidy bugprone-parent-virtual-call warnings
Fix clang-tidy bugprone-misplaced-widening-cast warnings
Fix clang-tidy bugprone-inc-dec-in-conditions warnings
Fix clang-tidy bugprone-multi-level-implicit-pointer-conversion warnings
Fix clang-tidy bugprone-macro-parentheses warnings
Fix clang-tidy bugprone-incorrect-roundings warnings
Fix clang-tidy bugprone-incorrect-division warnings
Fix clang-tidy bugprone-implicit-widening-of-multiplication-result warnings
Remove noexcept from util::tokenize_string
...
2025-05-27 11:59:46 -07:00
Tim Wojtulewicz
998479258a
Update .clang-tidy to have bugprone-* enabled with some exclusions
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
637a7732c0
Fix clang-tidy bugprone-unused-return-value warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
ae2ff9901b
Fix clang-tidy bugprone-unsafe-functions warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
d2045d1834
Fix clang-tidy bugprone-unused-local-non-trivial-variable warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
8bb015754a
Fix clang-tidy bugprone-throw-keyword-missing warnings
...
This one renames the Modbus Exception binpac type to ExcResponse. clang-tidy
insisted that anything named started with Exception was actually an exception
and needed to be thrown.
2025-05-27 11:58:27 -07:00
