For `|x|`, where `x` is an expression with an integral result, an
implicit coercion of that result into signed `int` type no longer takes
place.
This was actually the behavior before Zeek 3.0 as well, but the attempt
to prevent mistakes that easily result from integer literals in Zeek
being unsigned like `|5 - 9|` causing an overflow/wraparound and
yielding a very large number is not generally consistent since overflows
are still generally able to happen in other ways and also in other
contexts besides just absolute-values. So the preference was to revert
to a behavior that favors consistency. For reference, see
https://github.com/zeek/zeek/pull/251#issuecomment-713956976
* topic/seth/more-ignore-checksum-options:
Fixing how I define const on the Contains method.
Screwed up a change.
Changes in response to Johanna's code review.
Fixed a bug with ICMP checksum validation
Fixing a test
Accidentally missed a change.
Add an option to ignore packets sourced from particular subnets.
It's implemented with a new set[subnet] option named ignore_checksums_nets.
If you populate this set with subnets, any packet with a src address within
that set of subnets will not have it's checksum validated.
* topic/johanna/GH-169:
Make event ordering deterministic
dump-events: try to make baseline work on all systems
Introduce generate_all_events bif and add option to misc/dump-events
Fixes GH-169
* origin/topic/timw/1131-ip-handling:
Rework Sessions::Weird
Prevent String::Set from crashing if passed a nullptr
Store packet's ip header as unique_ptr
Remove some unused includes from Packet.h
Use shared_ptr for encapsulation data instead of raw pointer
Review cleanup
Update external testing repo hashes
Reorder Packet member variables slightly for better packing
Store the ip header in the packet after processing, reuse other places
Change to store data in packet directly instead of keystore
Don't always insert data into keystore for tunnels
Add comment about packet header size and session analysis
Set data to ip header's payload instead of advancing the pointer
Move packet dumping to packet_mgr
Make Sessions::NextPacket call packet_mgr, fix fuzzer code to do the same
Move IP and IP tunnel code from Sessions into packet analyzers
Prep work for IP changes
