This avoids a problem identified by amanbansal2709 in pull
request #1288. I fixed it in a different way than that pull request
by making sure the ts field is always set so that this isssue doesn't
return in the future.
The files framework uses strncpy to copy data into the buffer that is
used for IRC/FTP mime type detection. From all I can tell that means
that, in these cases, currently mime type detection will be messed up if
the data being passed in contains zero bytes.
This can improve performance significantly: ~3.5x faster when tested on
a large file passing data to the file analysis framework in small chunks
of 20 bytes.
- Removed a stray `printf()` from script-opt Reduce code
* origin/topic/vern/ast-opt: (23 commits)
Tweak minor const-ref/std::move things in script-opt code
Add alternative 'xform' baseline for test: broker.store.create-failure
Add explicit return value to Reducer::SameOp()
fixed AST transformation logic for boolean expressions
don't know how I overlooked these minor test suite updates
"opt" btest baseline updates due to AST optimizations changing printed code
"opt" baseline exceptions due to incompatibility with optimize-AST and -u
new "opt" btest alternative
update to "xform" test suite baseline due to recent line number changes
logic for driving AST optimization when requested
methods implementing AST optimization (aliasing, constant propagation, CSE)
helper class checking if common-subexpression elimination opportunity is valid
helper function for comparing collections of definition points
track more information about temporary variables
simplify and tidy up some interfaces
enable setting "-O optimize-AST" option
fix for reducing operations on boolean vectors
control whether checking for type-equivalence generates warnings
remove unneeded virtual method (same as inherited method)
accessors for additional Expr subclasses
...
* 'topic/keithjjones/openvpn' of https://github.com/keithjjones/zeek:
Replace assert with if statement so OpenVPN can use this over UDP. And fix spelling.
Broker::create_master() and Broker::create_clone() now return
a valid value even when there's a failure to open the backend database
(e.g. SQLite filesystem error). In that case, the returned value can
still be passed into other data store operations, but they'll fail
immediately with an error. Broker::is_closed() can now also be used to
determine whether the data store creation calls failed.
- Fixed leak in threading::Field copy-assignment operator
* origin/topic/timw/lgtm:
Use const-reference in plugin::Manager::MetaHookPost for minor performance gain
Fix missing assigmnent operator/copy constructor pairings reported by LGTM
Fix variable shadowing issues reported by LGTM
Update binpac and broker submodules to fix LGTM findings
- Applied minor spelling/grammar suggestions from Johanna during merge
* origin/topic/jsiwek/zeekygen-code-links:
Change update-zeekygen-docs.sh to set release branch in Sphinx config
Teach Zeekygen to produce source-code-range information
Add normalize_script_path() zeek::zeekygen::detail namespace
Add starts_with()/ends_with() to zeek::util namespace
