This takes the existing sorting for table index hashkeys we had in place during
hash key writes and applies it also during buffer size reservation. It changes
the approach slightly: the underlying map now points to the TableVal entry index
vals directly, rather than to the numerical index into an additional list that
gets built up to store those indexes. Doing so removes the need for that list.
Changes during merge:
- Add dedicated test (w/ trace "client_timestamp_enabled.pcapng" from Cloudshark)
- Change types from signed to unsigned.
- Add cast for bit-shifting operand.
- clang-format run
* origin/topic/timw/386-clang-format:
Minor fixes for build problems after reformatting
Reformat the world
Fixes for includes ahead of reformatting
GH-386: Add clang-format config and scripts
* origin/topic/vern/zam-coverity:
still more nit-squashing
avoiding using back() for an empty std::string
additional tweaks to address some compiler warnings
tweaks to address some compiler warnings
tweaks to address concerns flagged by Coverity
* origin/topic/seth/tsv-logs-utf8-by-default:
Fix mis-usage of string::append that leads to an overflow
Use json_escape_utf8 for all utf8 data in ODesc
Switch the TSV Zeek logs to be UTF8 by default.
* origin/topic/vern/ZAM-remainder: (37 commits)
fix race condition in btest output ordering
whoops, forgot to canonicalize filenames in new btest
extend btest to include a coercion overflow
fixed a typo in a comment
fixes for vector coercion overflows, typing, and holes
factoring out logic to check for overflows during coercions
test case for vector coercions, including holes
low-level cleanups found by code review
additional conversions of size() to empty() checks that were missed previously
indentation nit
flag loop that has slightly subtle logic
use ## to start major sections
a number of low-level tweaks from code review
use std::find_if rather than explicit loop
switch simple loops that don't need indices to being iterator-based
use container empty() rather than size() where appropriate
Baseline variants for "-a zam"
new "-a ZAM" testing baseline alternative
updates for usage issues: support for -uu, maybe/definitely distinctions
enable reducer to track folding to enable constant propagation
...
