mirror of
https://github.com/zeek/zeek.git
synced 2025-10-02 06:38:20 +00:00
6908d1b919
Previously, a single `icmp_conn` record was built per ICMP "connection"
and re-used for all events generated from it. This may have been a
historical attempt at performance optimization, but:
* By default, Zeek does not load any scripts that handle ICMP events.
* The one script Zeek ships with that does handle ICMP events,
"detect-traceroute", is already noted as being disabled due to
potential performance problems of doing that kind of analysis.
* Re-use of the original `icmp_conn` record tends to misreport
TTL and length values since they come from original packet instead
of the current one.
* Even if we chose to still re-use `icmp_conn` records and just fill
in a new TTL and length value each packet, a user script could have
stored a reference to the record and not be expecting those values
to be changed out from underneath them.
Now, a new `icmp_info` record is created/populated in all ICMP events
and should be used instead of `icmp_conn`. It also removes the
orig_h/resp_h fields as those are redundant with what's already
available in the connection record.
35 lines
1.5 KiB
Text
35 lines
1.5 KiB
Text
# These tests all check that ICMP6 events get raised with correct arguments.
|
|
|
|
# @TEST-EXEC: zeek -b -r $TRACES/icmp/icmp6-redirect-hdr-opt.pcap %INPUT >>output 2>&1
|
|
# @TEST-EXEC: zeek -b -r $TRACES/icmp/icmp6-nd-options.pcap %INPUT >>output 2>&1
|
|
|
|
# @TEST-EXEC: btest-diff output
|
|
|
|
event icmp_router_advertisement(c: connection, info: icmp_info, cur_hop_limit: count, managed: bool, other: bool, home_agent: bool, pref: count, proxy: bool, rsv: count, router_lifetime: interval, reachable_time: interval, retrans_timer: interval, options: icmp6_nd_options)
|
|
{
|
|
print "icmp_router_advertisement options";
|
|
for ( o in options )
|
|
{
|
|
print fmt(" %s", options[o]);
|
|
if ( options[o]$otype == 1 && options[o]?$link_address )
|
|
print fmt(" MAC: %s",
|
|
string_to_ascii_hex(options[o]$link_address));
|
|
}
|
|
}
|
|
|
|
event icmp_neighbor_advertisement(c: connection, info: icmp_info, router: bool, solicited: bool, override: bool, tgt: addr, options: icmp6_nd_options)
|
|
{
|
|
print "icmp_neighbor_advertisement options";
|
|
for ( o in options )
|
|
{
|
|
print fmt(" %s", options[o]);
|
|
if ( options[o]$otype == 2 && options[o]?$link_address ) print fmt(" MAC: %s", string_to_ascii_hex(options[o]$link_address));
|
|
}
|
|
}
|
|
|
|
event icmp_redirect(c: connection, info: icmp_info, tgt: addr, dest: addr, options: icmp6_nd_options)
|
|
{
|
|
print "icmp_redirect options";
|
|
for ( o in options )
|
|
print fmt(" %s", options[o]);
|
|
}
|