mirror of
https://github.com/zeek/zeek.git
synced 2025-10-03 07:08:19 +00:00
b745556d36
Previously, seq was computed as the result of |pending_commands|+1. This opened the possibility to override queued commands, as well as logging the same pending ftp reply multiple times. For example, when commands 1, 2, 3 are pending, command 1 may be dequeued, but the incoming command then receives seq 3 and overrides the already pending command 3. The second scenario happens when ftp_reply() selected command 3 as pending for logging, but is then followed by many ftp_request() events. This resulted in command 3's response being logged for every following ftp_request() over and over again. Avoid both scenarios by tracking the command sequence as an absolute counter.
1 line
41 B
Text
1 line
41 B
Text
9e2b8aaa316d6b818fa32c730fcc90ca8b401b68
|