mirror of
https://github.com/zeek/zeek.git
synced 2025-10-02 06:38:20 +00:00
672602dae7
We were parsing MySQL using bigendian even though the protocol is specified as with "least significant byte first" [1]. This is most problematic when parsing length encoded strings with 2 byte length fields... Further, I think, the EOF_Packet parsing was borked, either due to testing the CLIENT_DEPRECATE_EOF with the wrong endianness, or due to the workaround in Resultset processing raising mysql_ok(). Introduce a new mysql_eof() that triggers for EOF_Packet's and remove the fake mysql_ok() Resultset invocation to fix. Adapt the mysql script and tests to account for the new event. This is a quite backwards incompatible change on the event level, but due to being quite buggy in general, doubt this matters to many. I think there is more buried, but this fixes the violation of the simple "SHOW ENGINE INNODB STATUS" and the existing tests continue to succeed... [1] https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_basic_dt_integers.html
11 lines
371 B
Text
11 lines
371 B
Text
### BTest baseline data generated by btest-diff. Do not edit. Use "btest -U/-u" to update. Requires BTest >= 0.63.
|
|
mysql ok, 0
|
|
mysql request, 3, select @@version_comment limit 1
|
|
mysql eof, T
|
|
mysql result row, 1, MySQL Community Server - GPL
|
|
mysql eof, F
|
|
mysql request, 3, SHOW ENGINE INNODB STATUS
|
|
mysql eof, T
|
|
mysql result row, 3, InnoDB
|
|
mysql eof, F
|
|
mysql request, 1,
|