mirror of
https://github.com/zeek/zeek.git
synced 2025-10-02 14:48:21 +00:00

This PR changes the way in which the SSL analyzer tracks the direction of connections. So far, the SSL analyzer assumed that the originator of a connection would send the client hello (and other associated client-side events), and that the responder would be the SSL servers. In some circumstances this is not true, and the initiator of a connection is the server, with the responder being the client. So far this confused some of the internal statekeeping logic and could lead to mis-parsing of extensions. This reversal of roles can happen in DTLS, if a connection uses STUN - and potentially in some StartTLS protocols. This PR tracks the direction of a TLS connection using the hello request, client hello and server hello handshake messages. Furthermore, it changes the SSL events from providing is_orig to providing is_client, where is_client is true for the client_side of a connection. Since the argument positioning in the event has not changed, old scripts will continue to work seamlessly - the new semantics are what everyone writing SSL scripts will have expected in any case. There is a new event that is raised when a connection is flipped. A weird is raised if a flip happens repeatedly. Addresses GH-2198.
21 lines
717 B
Text
21 lines
717 B
Text
# @TEST-EXEC: zeek -b -r $TRACES/tls/webrtc-stun.pcap %INPUT
|
|
# @TEST-EXEC: btest-diff ssl.log
|
|
# @TEST-EXEC: touch dpd.log
|
|
# @TEST-EXEC: btest-diff dpd.log
|
|
# @TEST-EXEC: btest-diff .stdout
|
|
|
|
@load base/protocols/ssl
|
|
@load base/frameworks/dpd
|
|
|
|
redef SSL::log_include_client_certificate_subject_issuer = T;
|
|
redef SSL::log_include_server_certificate_subject_issuer = T;
|
|
|
|
event ssl_client_hello(c: connection, version: count, record_version: count, possible_ts: time, client_random: string, session_id: string, ciphers: index_vec, comp_methods: index_vec)
|
|
{
|
|
print version, client_random, session_id, ciphers;
|
|
}
|
|
|
|
event ssl_extension(c: connection, is_client: bool, code: count, val: string)
|
|
{
|
|
print is_client, code;
|
|
}
|