Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fix a memory leak with the CivetWeb callbacks in telemetry

Browse source
This commit is contained in:
Tim Wojtulewicz 2024-06-03 09:35:20 -07:00
parent 65678fbfdb
commit 32fe94f0f8
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/telemetry/Manager.cc
View file

@ -66,6 +66,9 @@ void Manager::InitPostScript() {
try { try {
prometheus_exposer = std::make_unique<prometheus::Exposer>(prometheus_url, 2, callbacks); prometheus_exposer = std::make_unique<prometheus::Exposer>(prometheus_url, 2, callbacks);
// CivetWeb stores a copy of the callbacks, so we're safe to delete the pointer here
delete callbacks;
} catch ( const CivetException& exc ) { } catch ( const CivetException& exc ) {
reporter->FatalError("Failed to setup Prometheus endpoint: %s\n", exc.what()); reporter->FatalError("Failed to setup Prometheus endpoint: %s\n", exc.what());
} }