SessionAdapter: Keep tap_analyzers until destruction

connection_state_remove() is invoked after Done(), so it's not a good
idea to remove the tap analyzers before in case they have up-to-date
information for the connection val.

Relates to #4337 #4725 #4734 #4737
This commit is contained in:
Arne Welzel 2025-08-06 16:53:28 +02:00
parent ee93213d39
commit bdff2935a4

View file

@ -12,9 +12,6 @@ void SessionAdapter::Done() {
Analyzer::Done();
for ( const auto& ta : tap_analyzers )
ta->Done();
// Ensure no more TapPacket() calls after Done() on TapAnalyzer instances.
tap_analyzers.clear();
}
bool SessionAdapter::IsReuse(double t, const u_char* pkt) { return parent->IsReuse(t, pkt); }