Mirror/zeek
1
0
Fork 0
mirror of https://github.com/zeek/zeek.git synced 2025-10-02 14:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Additional &is_used tags in the Netcontrol and Sumstats frameworks

Browse source 
When running a cluster, these functions only get called in select node types and
could trigger no-caller warnings on stderr.
This commit is contained in:
Christian Kreibich 2022-06-02 22:50:43 -07:00
parent 3ce1db1b5f
commit edef3736fb
2 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
scripts/base/frameworks/netcontrol/main.zeek
View file

@ -889,7 +889,7 @@ function remove_rule_impl(id: string, reason: string) : bool
return success; return success;
} }
function rule_expire_impl(r: Rule, p: PluginState) &priority=-5 function rule_expire_impl(r: Rule, p: PluginState) &priority=-5 &is_used
{ {
# do not emit timeout events on shutdown # do not emit timeout events on shutdown
if ( zeek_is_terminating() ) if ( zeek_is_terminating() )
@ -913,7 +913,7 @@ function rule_expire_impl(r: Rule, p: PluginState) &priority=-5
event NetControl::rule_timeout(r, FlowInfo(), p); # timeout implementation will handle the removal event NetControl::rule_timeout(r, FlowInfo(), p); # timeout implementation will handle the removal
} }
function rule_added_impl(r: Rule, p: PluginState, exists: bool, msg: string &default="") function rule_added_impl(r: Rule, p: PluginState, exists: bool, msg: string &default="") &is_used
{ {
if ( r$id !in rules ) if ( r$id !in rules )
{ {
@ -947,7 +947,7 @@ function rule_added_impl(r: Rule, p: PluginState, exists: bool, msg: string &def
} }
} }
function rule_removed_impl(r: Rule, p: PluginState, msg: string &default="") function rule_removed_impl(r: Rule, p: PluginState, msg: string &default="") &is_used
{ {
if ( r$id !in rules ) if ( r$id !in rules )
{ {
@ -973,7 +973,7 @@ function rule_removed_impl(r: Rule, p: PluginState, msg: string &default="")
rule_cleanup(rule); rule_cleanup(rule);
} }
function rule_timeout_impl(r: Rule, i: FlowInfo, p: PluginState) function rule_timeout_impl(r: Rule, i: FlowInfo, p: PluginState) &is_used
{ {
if ( r$id !in rules ) if ( r$id !in rules )
{ {
@ -1017,7 +1017,7 @@ function rule_timeout_impl(r: Rule, i: FlowInfo, p: PluginState)
rule_cleanup(rule); rule_cleanup(rule);
} }
function rule_error_impl(r: Rule, p: PluginState, msg: string &default="") function rule_error_impl(r: Rule, p: PluginState, msg: string &default="") &is_used
{ {
if ( r$id !in rules ) if ( r$id !in rules )
{ {

2
scripts/base/frameworks/sumstats/main.zeek
View file

@ -548,7 +548,7 @@ function check_thresholds(ss: SumStat, key: Key, result: Result, modify_pct: dou
return F; return F;
} }
function threshold_crossed(ss: SumStat, key: Key, result: Result) function threshold_crossed(ss: SumStat, key: Key, result: Result) &is_used
{ {
# If there is no callback, there is no point in any of this. # If there is no callback, there is no point in any of this.
if ( ! ss?$threshold_crossed ) if ( ! ss?$threshold_crossed )