Remove using util.h in various headers in favor of util-types.h

src/Desc.h

@@ -9,7 +9,7 @@
 
 #include "zeek/IntrusivePtr.h"
 #include "zeek/ZeekString.h" // for byte_vec
-#include "zeek/util.h"       // for zeek_int_t
+#include "zeek/util-types.h"
 
 namespace zeek {
 

src/Event.h

@@ -9,7 +9,7 @@
 #include "zeek/ZeekArgs.h"
 #include "zeek/analyzer/Analyzer.h"
 #include "zeek/iosource/IOSource.h"
-#include "zeek/util.h"
+#include "zeek/util-types.h"
 
 namespace zeek {
 

src/Frag.h

@@ -8,7 +8,7 @@
 #include "zeek/IPAddr.h"
 #include "zeek/Reassem.h"
 #include "zeek/Timer.h"
-#include "zeek/util.h" // for zeek_uint_t
+#include "zeek/util-types.h"
 
 namespace zeek {
 

src/Hash.h

@@ -22,7 +22,7 @@
 #include <unistd.h>
 #include <cstdlib>
 
-#include "zeek/util.h" // for zeek_int_t
+#include "zeek/util-types.h" // for zeek_int_t
 
 // to allow md5_hmac_bif access to the hmac seed
 #include "zeek/ZeekArgs.h"

src/Overflow.h

@@ -2,9 +2,14 @@
 
 #pragma once
 
-#include "zeek/Type.h"
+#include "zeek/util-types.h"
 
-namespace zeek::detail {
+namespace zeek {
+
+class Type;
+class Val;
+
+namespace detail {
 
 inline bool double_to_count_would_overflow(double v) { return v < 0.0 || v > static_cast<double>(UINT64_MAX); }
 
@@ -18,4 +23,5 @@ inline bool count_to_int_would_overflow(zeek_uint_t v) { return v > INT64_MAX; }
 
 extern bool would_overflow(const zeek::Type* from_type, const zeek::Type* to_type, const Val* val);
 
-} // namespace zeek::detail
+} // namespace detail
+} // namespace zeek

src/UID.h

@@ -5,7 +5,7 @@
 #include <cstring>
 #include <string>
 
-#include "zeek/util.h" // for zeek_int_t
+#include "zeek/util-types.h"
 
 namespace zeek {
 

src/analyzer/Component.h

@@ -4,7 +4,6 @@
 
 #include "zeek/Tag.h"
 #include "zeek/plugin/Component.h"
-#include "zeek/util.h"
 
 namespace zeek {
 

src/binpac_zeek-lib.pac

@@ -1,7 +1,7 @@
 %extern{
 #include "zeek/3rdparty/ConvertUTF.h"
 #include "zeek/binpac_zeek.h"
-#include "zeek/util.h"
+#include "zeek/util-types.h"
 #include "zeek/Reporter.h"
 #include "zeek/Val.h"
 #include "zeek/RunState.h"

src/digest.h

@@ -10,7 +10,7 @@
 #include <cstdint>
 #include <cstdio>
 
-#include "zeek/util.h"
+#include "zeek/util.h" // for util::bytetohex
 
 // Required buffer size for an MD5 digest.
 #define ZEEK_MD5_DIGEST_LENGTH 16

src/iosource/BPF_Program.h

@@ -5,7 +5,7 @@
 #include <cstdint>
 #include <string>
 
-#include "zeek/util.h"
+#include "zeek/util-types.h"
 
 extern "C" {
 #include <pcap.h>

src/packet_analysis/Component.h

@@ -6,7 +6,6 @@
 
 #include "zeek/Tag.h"
 #include "zeek/plugin/Component.h"
-#include "zeek/util.h"
 
 namespace zeek::packet_analysis {
 

src/script_opt/ZAM/Frame.h

@@ -8,7 +8,7 @@
 
 #include "zeek/Attr.h"
 #include "zeek/ID.h"
-#include "zeek/util.h"
+#include "zeek/util-types.h"
 
 namespace zeek::detail {
 

src/script_opt/ZAM/Support.h

@@ -9,11 +9,13 @@
 
 #pragma once
 
+#include <memory>
+#include <string>
 #include <vector>
 
 #include "zeek/IntrusivePtr.h"
 #include "zeek/script_opt/ZAM/Profile.h"
-#include "zeek/util.h"
+#include "zeek/util-types.h"
 
 namespace zeek {
 

src/telemetry/MetricFamily.h

@@ -6,7 +6,7 @@
 #include <vector>
 
 #include "zeek/Span.h"
-#include "zeek/util.h"
+#include "zeek/util-types.h"
 
 namespace zeek::telemetry {