In half-duplex setups (or when client/server coalesce the SSH version
line with the KEX packet, get_version() would return UNK as version,
causing a protocol violation. Make this slightly more robust by using
and setting the version which either side had set to continue parsing.
For the special case of SSH-1.99, select SSH-2.0. We could try to peak
into the payload following the packet length field and check for
a KEX_INIT type byte to select SSH2 as a heuristic, but not sure how
to accomplish this.
Slight regression fix for 3769ed6c66
which started to require visibility for client and server version
rather than just the client's version.
This reverts part of commit a0888b7e36 due
to inhibiting analyzer violations when parsing non SSH traffic when
the &restofdata path is entered.
@J-Gras reported the analyzer not being disabled when sending HTTP
traffic on port 22.
This adds the verbose analyzer.log baselines such that future improvements
of these scenarios become visible.
When CCACHE_BASEDIR is set, ccache will rewrite absolute paths to
relative paths in order to allow compilation in different source
directories. We do not need this feature on Cirrus (the checkout
is always in /zeek) and using absolute paths avoids
confusion/normalization needs for the gcov -p results.
We could consider removing the global CCACHE_BASEDIR, but it'd
bust the ccache of every other task, too.
* origin/topic/timw/telemetry-follow-up:
Switch to zeek fork of prometheus-cpp
Remove unnecessary shared_from_this on instrument classes
Restore label_names field in MetricOpts record
Change how we count FDs on Linux to fix zeekctl stop issues
Update zeekctl tests for telemetry rework
Use forward declarations of prometheus-cpp types in telemetry::Manager
Add prometheus-cpp files to install set for plugins to use
Fix a memory leak with the CivetWeb callbacks in telemetry
Fix a bunch of copy-instead-of-move findings from Coverity
Move telmetry label names out of opts records, into main metric records
Ensure the order of label values matches the label names
Remove prefix column from telemetry.log
Fix race condition by pre-building the cluster json data for services.json
Set running_under_test for scripts.base.frameworks.logging.telemetry test
* origin/topic/vern/script-opt-maint.Jun24:
script optimization baseline tweaks due to recent minor changes
updated list of BiFs for script optimization
addressed some Coverity nits
improved error cascade for invalid attributes
* topic/timw/prometheus-cpp-3: (35 commits)
Update docs submodule [nomail] [skip ci]
Add type aliases for instrument and family shared_ptrs
Update NEWS for double and is_sum changes
Remove is_sum arguments from counters and gauges
Change all instruments to only handle doubles
Add comment to telemetry::Manager::InitPostScript
Remove all of the ZEEK_METRICS_ environment variables
Fix header comments in scripts/policy/frameworks/telemetry/prometheus.zeek
Change all prometheus #includes to use angle brackets
Update zeekctl submodule for metrics_port node.cfg option
Regenerate docs [nomail]
Remove the is_sum argument from BIF histogram creation methods
Update NEWS for Telemetry rework
Remove Telemetry::metrics_export_prefixes option
Validate that label names are constant in non-zeek metrics
Avoid calling Collect() in counter/gauge Value() methods if not needed
Fix some determinism issues with btests
Temporarily disable the scripts/base/frameworks/telemetry/internal-metrics btest
Fix the scripts.policy.frameworks.telemetry.prometheus btest to use the service discovery endpoint
Btest updates due to recent changes
...
