Tim Wojtulewicz
144a3dee3a
Fix clang-tidy performance-move-const-argument warnings (moving const variables)
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
6196950567
Fix clang-tidy performance-inefficient-vector-operation warnings
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
b8e28abb97
Fix clang-tidy performance-for-range-copy warnings
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
178d7f4cd0
Fix clang-tidy performance-faster-string-find warnings
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
f4c47d0357
Fix clang-tidy performance-enum-size warnings
2025-05-30 08:12:29 -07:00
Tim Wojtulewicz
11a1d8d506
Fix clang-tidy performance-avoid-endl warnings
2025-05-30 08:02:55 -07:00
Arne Welzel
10bfb34a8a
Update doc submodule [nomail] [skip ci]
...
Fix botched last-minute cleanup.
2025-05-30 16:49:10 +02:00
Arne Welzel
1d241fabf4
Merge remote-tracking branch 'origin/topic/awelzel/zeekygen-field-directive'
...
* origin/topic/awelzel/zeekygen-field-directive:
Bump doc submodule for ext/zeek.py modifications
RecordType:DescribeReST: Render RecordType using zeek:field directive
2025-05-30 16:44:42 +02:00
Arne Welzel
f16ebd34b3
Merge remote-tracking branch 'origin/topic/awelzel/4474-cluster-websocket-ipv6'
...
* origin/topic/awelzel/4474-cluster-websocket-ipv6:
IXWebsocket: Bump to version with memset() sock addr fix
cluster/websocket: Deprecate $listen_host, introduce $listen_addr
cluster/websocket-ixwebsocket: Determine proper address_family
2025-05-30 11:47:55 +02:00
Arne Welzel
66fef5a9bd
IXWebsocket: Bump to version with memset() sock addr fix
2025-05-30 11:02:41 +02:00
Arne Welzel
544d571089
cluster/websocket: Deprecate $listen_host, introduce $listen_addr
...
This only changes the script-layer API, but keeps the std::string host
in the C++ layer's ServerOptions. Mostly because the ixwebsocket library
takes host as std::string. Also, maybe at some point we'd want to
support something scheme-based like unix:///var/run/zeek.sock and placing
that in a string could not be totally wrong.
Add tests for IPV6, too.
2025-05-30 11:02:41 +02:00
Arne Welzel
8b029d0050
cluster/websocket-ixwebsocket: Determine proper address_family
...
Closes #4474
2025-05-30 11:01:31 +02:00
Tim Wojtulewicz
372986f052
Update docs submodue [nomail] [skip ci]
2025-05-28 11:44:09 -07:00
Tim Wojtulewicz
2d7aad2c81
Merge remote-tracking branch 'origin/topic/timw/remove-with-bind'
...
* origin/topic/timw/remove-with-bind:
Remove obsolete --with-bind configure flag
2025-05-28 08:29:50 -07:00
Arne Welzel
871e81dd6a
Bump doc submodule for ext/zeek.py modifications
2025-05-28 16:18:44 +02:00
Arne Welzel
71fb301e3d
RecordType:DescribeReST: Render RecordType using zeek:field directive
...
This is for zeek/zeek-docs#324 .
2025-05-28 15:59:50 +02:00
Tim Wojtulewicz
9db9861f75
Remove obsolete --with-bind configure flag
2025-05-27 17:55:49 -07:00
zeek-bot
9ffc87a90e
Update doc submodule [nomail] [skip ci]
2025-05-28 00:38:27 +00:00
Tim Wojtulewicz
88ae3ba412
Merge remote-tracking branch 'origin/topic/timw/coverity'
...
* origin/topic/timw/coverity:
Add a few std::moves to fix Coverity warnings
Fix possible memory leak in broker::Manager
fixup! Use SCN* constants when reading into sized integer types
from_json: Statically lookup err index in result type
Use SCN* constants when reading into sized integer types
Remove setting unused variable value in FTP::parse_eftp
2025-05-27 12:49:13 -07:00
Tim Wojtulewicz
e4ab1a3b1d
Add a few std::moves to fix Coverity warnings
2025-05-27 12:03:45 -07:00
Tim Wojtulewicz
ff7c908460
Fix possible memory leak in broker::Manager
2025-05-27 12:03:45 -07:00
Tim Wojtulewicz
54c5a470bd
fixup! Use SCN* constants when reading into sized integer types
2025-05-27 12:03:45 -07:00
Tim Wojtulewicz
a6437142ce
from_json: Statically lookup err index in result type
2025-05-27 12:03:45 -07:00
Tim Wojtulewicz
1992a55798
Use SCN* constants when reading into sized integer types
2025-05-27 12:03:45 -07:00
Tim Wojtulewicz
ff4d1a4121
Remove setting unused variable value in FTP::parse_eftp
2025-05-27 12:03:45 -07:00
Tim Wojtulewicz
aaca36dc22
Merge remote-tracking branch 'origin/topic/timw/clang-tidy-bugprone-fixes'
...
* origin/topic/timw/clang-tidy-bugprone-fixes: (22 commits)
Update .clang-tidy to have bugprone-* enabled with some exclusions
Fix clang-tidy bugprone-unused-return-value warnings
Fix clang-tidy bugprone-unsafe-functions warnings
Fix clang-tidy bugprone-unused-local-non-trivial-variable warnings
Fix clang-tidy bugprone-throw-keyword-missing warnings
Fix clang-tidy bugprone-switch-missing-default-case warnings
Fix clang-tidy bugprone-suspicious-realloc-usage warnings
Fix clang-tidy bugprone-suspicious-include warnings
Fix clang-tidy bugprone-suspicious-string-compare warnings
Fix clang-tidy bugprone-suspicious-stringview-data-usage warnings
Fix clang-tidy bugprone-string-literal-with-embedded-nul warnings
Fix clang-tidy bugprone-parent-virtual-call warnings
Fix clang-tidy bugprone-misplaced-widening-cast warnings
Fix clang-tidy bugprone-inc-dec-in-conditions warnings
Fix clang-tidy bugprone-multi-level-implicit-pointer-conversion warnings
Fix clang-tidy bugprone-macro-parentheses warnings
Fix clang-tidy bugprone-incorrect-roundings warnings
Fix clang-tidy bugprone-incorrect-division warnings
Fix clang-tidy bugprone-implicit-widening-of-multiplication-result warnings
Remove noexcept from util::tokenize_string
...
2025-05-27 11:59:46 -07:00
Tim Wojtulewicz
998479258a
Update .clang-tidy to have bugprone-* enabled with some exclusions
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
637a7732c0
Fix clang-tidy bugprone-unused-return-value warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
ae2ff9901b
Fix clang-tidy bugprone-unsafe-functions warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
d2045d1834
Fix clang-tidy bugprone-unused-local-non-trivial-variable warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
8bb015754a
Fix clang-tidy bugprone-throw-keyword-missing warnings
...
This one renames the Modbus Exception binpac type to ExcResponse. clang-tidy
insisted that anything named started with Exception was actually an exception
and needed to be thrown.
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
2c2a595af5
Fix clang-tidy bugprone-switch-missing-default-case warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
b20419efaf
Fix clang-tidy bugprone-suspicious-realloc-usage warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
f643d02bf8
Fix clang-tidy bugprone-suspicious-include warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
4d60d4833e
Fix clang-tidy bugprone-suspicious-string-compare warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
975f24bde6
Fix clang-tidy bugprone-suspicious-stringview-data-usage warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
02589c349a
Fix clang-tidy bugprone-string-literal-with-embedded-nul warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
74acc30258
Fix clang-tidy bugprone-parent-virtual-call warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
b3de432ef2
Fix clang-tidy bugprone-misplaced-widening-cast warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
184757b3db
Fix clang-tidy bugprone-inc-dec-in-conditions warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
d0bbc61bd4
Fix clang-tidy bugprone-multi-level-implicit-pointer-conversion warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
9e83759e83
Fix clang-tidy bugprone-macro-parentheses warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
1d315a3847
Fix clang-tidy bugprone-incorrect-roundings warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
87f1b1a7b3
Fix clang-tidy bugprone-incorrect-division warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
18983aed02
Fix clang-tidy bugprone-implicit-widening-of-multiplication-result warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
bdb0fad6d5
Remove noexcept from util::tokenize_string
...
One instance of this method is noexcept and one isn't. The version
that is noexcept uses std::vector::emplace_back, which may throw
exceptions. Instead of adding a try/catch block, opt for just making
the two functions able to throw exceptions.
This fixes a clang-tidy bugprone-exception-escape warning.
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
dbecfb5a2a
Fix clang-tidy bugprone-branch-clone warnings
2025-05-27 11:58:27 -07:00
Tim Wojtulewicz
92854e95d3
Fix clang-tidy bugprone-assignment-in-if-condition warnings
2025-05-27 11:58:27 -07:00
Johanna Amann
8ce741a7a8
Merge remote-tracking branch 'origin/topic/johanna/gh-4463'
...
* origin/topic/johanna/gh-4463:
Add explicit TLS support for FTP
2025-05-27 17:47:52 +01:00
Johanna Amann
718307214e
Add explicit TLS support for FTP
...
This is defined in RFC 4217; TLS initialized by the client sending an
`AUTH TLS` command.
Fixes GH-4463
2025-05-27 16:57:51 +01:00
