- Daniel Guerra pointed out a type issue for SIP
request and response code length fields which is now
corrected.
- Some redundant code was removed.
- if/else tree modified to use switch instead.
Lowered priority of a connection_state_remove event handler to ensure
that the "conn" field is initialized in the connection record before
attempting to add the VLAN tags.
Cleaned up the surrounding code a bit and also added '[' as another
case (not sure that can happen, but doesn't hurt eihter).
* 'master' of https://github.com/aeppert/bro:
Whitespace
Remove
Remove.
Fix for JSON formatter
A fatal error, especially in DEBUG, should result in a core.
Seems to fix a case where an entry in the table may be null on insert.
In the event that the first entry in a record is optional AND not present, the serializer will incorrectly add a leading comma. This leading common is invalid JSON and will, more often than not, cause parser failures downstream.
The alert in this case is caused by the server name in the SNI not being
recognized by the server, which triggers an alert. Since the server is
an apache, and this might happen reasonably often, the new signature
allows one TLS alert before the server hello is expected.
Without this patch, this scenario results in a segmentation fault.
I opted to keep the separator present for non-existing elements. Hence,
a vector a, [empty], b with separator "|" will result in
a||b
* origin/topic/dnthayer/ticket1467:
Load static CA list for validation tests too.
Remove cluster certificate validation script for the moment.
Fix a bug in diff-remove-x509-names canonifier
Fix some test canonifiers in scripts/policy/protocols/ssl
BIT-1467 #merged
* origin/topic/yunzheng/x509-generalizedtime:
Make x509 end-of-string-check nicer.
Refactor X509 generalizedtime support and test.
Fixed parsing of V_ASN1_GENERALIZEDTIME timestamps in x509 certificates
BIT-1481 #merged
* origin/topic/dnthayer/ticket1481:
Improve a few test canonifiers
Remove unnecessary use of TEST_DIFF_CANONIFIER
Fixed some test canonifiers to read only from stdin
